[LU-10883] llog backup files processing is not skipped because of string сomparison error Created: 05/Apr/18  Updated: 04/Jan/19  Resolved: 04/Jan/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.11.0
Fix Version/s: Lustre 2.13.0

Type: Bug Priority: Major
Reporter: Artem Blagodarenko (Inactive) Assignee: Artem Blagodarenko (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-7160 Saved by change_nids .bak files on MG... Resolved
is related to LU-11648 Create white list for CONFIGS directo... Open
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Buggy code was introduced in LU-7160 fix

		/* filter out ".bak" files */
		/* sizeof(".bak") - 1 == 3 */
		if (key_sz >= 3 &&
		    !memcmp(".bak", key + key_sz - 3, 3)) {
			CDEBUG(D_MGS, "Skipping backup file %.*s\n",
			       key_sz, key);
			goto next;
		}

4 last key's bytes need to be compared with ".bak"



 Comments   
Comment by Gerrit Updater [ 05/Apr/18 ]

Artem Blagodarenko (c17828@cray.com) uploaded a new patch: https://review.whamcloud.com/31886
Subject: LU-10883 llog: fix backup file name comparison
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e494b6f87ae2ef80c62b4fda2fd461d7214143c2

Comment by Gerrit Updater [ 04/Jan/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/31886/
Subject: LU-10883 llog: fix backup file name comparison
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5bc7ee090d6475ccd60785e120a21ecbbed3baa4

Comment by Peter Jones [ 04/Jan/19 ]

Landed for 2.13

Generated at Sat Feb 10 02:39:01 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.