[LU-10966] `lfs check` documentation is misleading Created: 28/Apr/18  Updated: 22/Dec/22  Resolved: 23/Jan/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.13.0

Type: Bug Priority: Minor
Reporter: George Melikov Assignee: James A Simmons
Resolution: Fixed Votes: 0
Labels: None

Attachments: File 0001-Fix-lfs-check-documentation-and-arguments.patch    
Issue Links:
Related
is related to LU-8066 Move lustre procfs handling to sysfs ... Open
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

`lfs check` command documentation and arguments are misleading,
it is used to check targets, not servers, as documentation states (or am I wrong?).

 

I propose to change man page and add new arguments:

  • mdts
  • all

Proposing patch is in attachment.



 Comments   
Comment by Joseph Gmitter (Inactive) [ 30/Apr/18 ]

The patch is for man page updates, therefore it should be moved to an LU ticket.

Comment by George Melikov [ 15/May/18 ]

Unfortunately, I can't push patch, is something wrong with command?

git push ssh://gmelikov@review.whamcloud.com:29418/fs/lustre-release master

fatal: Upload denied for project 'fs/lustre-release'
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
Comment by Minh Diep [ 15/May/18 ]

Please see https://wiki.hpdd.intel.com/display/PUB/Using+Gerrit for how to contribute patches

Comment by James A Simmons [ 15/May/18 ]

Note your fix has been merged into https://review.whamcloud.com/#/c/31618

Comment by George Melikov [ 16/May/18 ]

@simmonsja Thank you!

@mdiep I've used exactly this page, this command didn't work for me too

git push ssh://gmelikov@review.whamcloud.com:29418/fs/lustre-release HEAD:refs/for/master

 

Comment by Minh Diep [ 16/May/18 ]

melikov, you should be able to do that now. we have added you to the list.

Comment by George Melikov [ 16/May/18 ]

Minh Diep, thank you, I'll try it on my next contribution.

Comment by Gerrit Updater [ 04/Dec/18 ]

James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33775
Subject: LU-10966 utils: Fix `lfs check` documentation and arguments
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 54cb5f6bafe36552811398367e0a957da99931cb

Comment by Gerrit Updater [ 23/Jan/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33775/
Subject: LU-10966 utils: Fix `lfs check` documentation and arguments
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0652c828c93f266b9999883b1b2967bfaac11c89

Comment by Gerrit Updater [ 22/Dec/22 ]

"Etienne AUJAMES <eaujames@ddn.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/49493
Subject: LU-10966 utils: Fix `lfs check` documentation and arguments
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 61bcd9c7a0a47fbfed3c14a1ab4d00b85e065687

Generated at Sat Feb 10 02:39:46 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.