[LU-110] Allow the use of a 2.0 MDS on a filesystem with a 1.8 disk format Created: 04/Mar/11  Updated: 20/Nov/12  Resolved: 05/Oct/11

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.0.0, Lustre 2.1.0
Fix Version/s: Lustre 2.2.0, Lustre 2.1.1

Type: Bug Priority: Major
Reporter: Nikitas Angelinas Assignee: Niu Yawei (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Attachments: File LU-110_Old_style_quota_type_handling_fix.patch    
Severity: 3
Epic: MDS, config, quota
Rank (Obsolete): 4895

 Description   

Version 1.8 uses a tunable named "mdt.quota_type" in order to store quota parameters in config, while version 2.x has a tunable named "mdd.quota_type" for the same purpose. This introduces incompatibility when trying to run a 2.x Lustre instance on top of a filesystem with a 1.8 disk format.



 Comments   
Comment by Peter Jones [ 04/Mar/11 ]

Niu

Could you please look into this?

Thanks

Peter

Comment by Peter Jones [ 04/Mar/11 ]

Nikita

Do Xyratex have a patch to share for this issue? It sounded like you did on the the 2.1 call on Tuesday

Thanks

Peter

Comment by Nikitas Angelinas [ 04/Mar/11 ]

Hi Peter,

Yes we did. However, I was having trouble when I tried to push the patch to Gerrit earlier today; the patch had been written by Shadow, so Gerrit was complaining that I was not the committer, as such:

>>> ! [remote rejected] HEAD -> refs/for/master (you are not committer
>>> alexey_lyashkov@xyratex.com)
>>> error: failed to push some refs to 'ssh://review/fs/lustre-release'

We were ideally looking for a way to have a single submitter for the patches we send inspection requests for to Whamcloud. I guess we may have to create a separate account for each Xyratex Lustre developer?

If there is no obvious way for me to upload the patch, I will see if I can get Shadow to do it.

Regards,
Nikitas

Comment by Niu Yawei (Inactive) [ 06/Mar/11 ]

For such kind of config incompatible issue, I think we can either fix it in later Lustre version (make 2.0 Lustre recognizing 1.8 config), or fix the config while upgrading (provide a script to replace incompatible config or ask user to do it mannually).

Hi, Peter
Looks Xyrate already has a patch to fix it, so I think we should reivew and merge that one instead of generate another one, right?

Thanks

  • Niu
Comment by Peter Jones [ 07/Mar/11 ]

Niu

I think that we need to do the former. Yes, Xyratex have a patch but they are currently blocked on providing it until we can give Nikitas some guidance about how to supply the patch. I suggest that you create a repro case as a first step and then see whether the patch is available by then. If not it probably would not be too much effort to recreate it - I gather from Nathan (of Xx) that it is only a few lines of code (though of course it would be preferable to reuse the existing patch)

Peter

Comment by Nikitas Angelinas [ 07/Mar/11 ]

Hi Niu and Peter,

Please find attached a patch for the issue; hopefully the formatting of the file has been left intact by the upload process.

Thanks to Robert Read for providing us with the necessary Gerrit-related information; we should be sorting out our upstreaming methodology soon hopefully.

Kind Regards,
Nikitas

Comment by Build Master (Inactive) [ 18/Mar/11 ]

Integrated in reviews-centos5 #502
LU-110 Old-style quota type handling fix

Vitaly Fertman : b4f6461fcdbd6ca001d48653075601be66432da3
Files :

  • lustre/mdt/mdt_lproc.c
  • lustre/mdd/mdd_lproc.c
Comment by Build Master (Inactive) [ 22/Mar/11 ]

Integrated in reviews-centos5 #536
LU-110 Recognize old mdt.quota_type param

Niu Yawei : 4e57da69d1159bd2d2bec9e12cc724f8044443d2
Files :

  • lustre/mdt/mdt_handler.c
Comment by Niu Yawei (Inactive) [ 26/Aug/11 ]

http://review.whamcloud.com/#change,354

Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,ofa #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » i686,server,el6,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,ofa #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » i686,client,el6,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » i686,server,el5,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » i686,client,el5,ofa #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » i686,client,el5,inkernel #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Build Master (Inactive) [ 05/Oct/11 ]

Integrated in lustre-master » i686,server,el5,ofa #287
LU-110 Recognize old mdt.quota_type param

Oleg Drokin : 398fd6e9da8c845efb45bdc6b0af2c8440219d7e
Files :

  • lustre/mdt/mdt_handler.c
Comment by Peter Jones [ 05/Oct/11 ]

Landed for 2.2

Comment by Nathan Rutman [ 20/Nov/12 ]

Xyratex: MRP-106

Generated at Sat Feb 10 01:03:51 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.