[LU-11010] Remove call to ‘return’ after call to ‘skip’ in Lustre test suites Created: 09/May/18 Updated: 08/Apr/19 Resolved: 03/Mar/19 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.13.0, Lustre 2.10.7, Lustre 2.12.1 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | James Nunez (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | test_script_improvements, tests | ||
| Issue Links: |
|
||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
With the patch for 5776 skip_noexit() {
5777 echo
5778 log " SKIP: $TESTSUITE $TESTNAME $@"
5779
5780 if [[ -n "$ALWAYS_SKIPPED" ]]; then
5781 skip_logged $TESTNAME "$@"
5782 else
5783 mkdir -p $LOGDIR
5784 echo "$@" > $LOGDIR/skip
5785 fi
5786
5787 [[ -n "$TESTSUITELOG" ]] &&
5788 echo "$TESTSUITE: SKIP: $TESTNAME $@" >> $TESTSUITELOG || true
5789 }
5790
5791 skip() {
5792 skip_noexit
5793 exit 0
5794 }
Tests that have calls to skip() or skip_env() should be reviewed to see if they should be converted to skip_noexit() or remove the call to return that follows the call to skip. |
| Comments |
| Comment by Gerrit Updater [ 09/May/18 ] |
|
James Nunez (james.a.nunez@intel.com) uploaded a new patch: https://review.whamcloud.com/32346 |
| Comment by Gerrit Updater [ 29/May/18 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/32346/ |
| Comment by Peter Jones [ 29/May/18 ] |
|
Landed for 2.12
|
| Comment by James Nunez (Inactive) [ 26/Jun/18 ] |
|
There are many test suites that still call return() after skip(). All of these call need to be reviewed and determined if we can just remove the return call or need to call skip_noexit() or some other action. |
| Comment by Gerrit Updater [ 30/Jul/18 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32731/ |
| Comment by Gerrit Updater [ 16/Sep/18 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32732/ |
| Comment by Peter Jones [ 16/Sep/18 ] |
|
jamesanunez so is that the lot now? |
| Comment by James Nunez (Inactive) [ 02/Oct/18 ] |
|
Two more patches need a little work and need to land to finish up this work; |
| Comment by Gerrit Updater [ 23/Oct/18 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32733/ |
| Comment by Gerrit Updater [ 06/Feb/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34199 |
| Comment by Gerrit Updater [ 15/Feb/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34199/ |
| Comment by Gerrit Updater [ 03/Mar/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32735/ |
| Comment by Peter Jones [ 03/Mar/19 ] |
|
Landed for 2.13 |
| Comment by Gerrit Updater [ 01/Apr/19 ] |
|
Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34565 |
| Comment by Gerrit Updater [ 08/Apr/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34565/ |