[LU-11050] mdd: modifying changelog_deniednext does not yield immediate result Created: 23/May/18  Updated: 05/Aug/20

Status: Open
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Minor
Reporter: CEA Assignee: Sebastien Buisson
Resolution: Unresolved Votes: 0
Labels: None

Issue Links:
Related
is related to LU-9727 Lustre Audit with Changelogs Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

From what I could read in mdd_object.c the procfile changelog_deniednext is the number of seconds to wait before logging another NOPEN changelog record.

The implementation computes a deadline once (when an NOPEN is logged) instead of comparing the current time + the timeout. This means that if somebody sets the timeout to 3600s, produces an NOPEN changelog and then sets back the timeout to 60s, one will still need to wait an hour to see the next NOPEN changelog.



 Comments   
Comment by Peter Jones [ 23/May/18 ]

Quentin

Is this something that you are planning to work on?

Peter

Comment by Quentin Bouget [ 23/May/18 ]

I was hoping someone else could do it...

Comment by Peter Jones [ 23/May/18 ]

Sebastien

Could you please comment?

Thanks

Peter

Comment by Sebastien Buisson (Inactive) [ 25/May/18 ]

Hi,

What you describe is how the changelog_deniednext tunable was designed. As the name tends to suggest, it defines when the next NOPEN Changelog entry will be recorded, counting from the last recorded entry.
This implementation was suggested by Andreas. It is slightly more efficient to add changelog_deniednext delay when saving denied time, and then just compare against that, instead of adding changelog_deniednext delay to denied time for each check.

Thanks,
Sebastien.

Comment by Quentin Bouget [ 28/May/18 ]

How about re-computing the deadline everytime the proc file is written to?

Generated at Sat Feb 10 02:40:30 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.