[LU-11096] Lustre doesn't build if kernel has no blk integrity Created: 24/Jun/18  Updated: 23/Aug/18  Resolved: 23/Aug/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.12.0

Type: Improvement Priority: Trivial
Reporter: Alex Zhuravlev Assignee: Alex Zhuravlev
Resolution: Fixed Votes: 0
Labels: None
Environment:

linux-3.10.0-327.18.2.el7


Issue Links:
Duplicate
duplicates LU-11274 Compile failure when CONFIG_BLK_DEV_I... Closed
Related
is related to LU-11224 T10PI assume several kernel features ... Resolved
Rank (Obsolete): 9223372036854775807

 Description   

wrap corresponding functionality with HAVE_BLK_INTEGRITY_ENABLED

 



 Comments   
Comment by Chris Horn [ 21/Aug/18 ]

Adding my description from LU-11274 to make this more discoverable:

Similar to LU-11224, the T10PI feature assumes that CONFIG_BLK_DEV_INTEGRITY=y is set.

I see this on SLES 12 SP3, but presumably similar failures would occur on any kernel.

[  232s] In file included from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lvfs.h:45:0,
[  232s]                  from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/obd.h:53,
[  232s]                  from /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/fid/fid_request.c:43:
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h: In function 'blk_integrity_interval':
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h:708:11: error: dereferencing pointer to incomplete type
[  232s]   return bi->sector_size; 
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h: In function 'blk_integrity_name':
[  232s] /home/abuild/rpmbuild/BUILD/cray-lustre-2.11.53.87/lustre/include/lustre_compat.h:717:11: error: dereferencing pointer to incomplete type
[  232s]   return bi->name;
Comment by Chris Horn [ 21/Aug/18 ]

Not sure why we don't have a comment with the patch -  https://review.whamcloud.com/#/c/32725

Comment by Gerrit Updater [ 23/Aug/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32725/
Subject: LU-11096 osd: wrap new blk integrity stuff
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c8505c2e70d03ba20edf9fcbf431888e87a21147

Comment by Peter Jones [ 23/Aug/18 ]

Landed for 2.12

Generated at Sat Feb 10 02:40:54 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.