[LU-11114] Track creates in MDC and llite stats Created: 03/Jul/18  Updated: 14/Apr/20  Resolved: 01/Feb/20

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.4
Fix Version/s: Lustre 2.14.0, Lustre 2.12.5

Type: Bug Priority: Minor
Reporter: Olaf Faaland Assignee: Emoly Liu
Resolution: Fixed Votes: 0
Labels: llnl
Environment:

RHEL 7.5

Issue Links:
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

File creates are not tracked in llite stats. Andreas mentioned this in LU-8150. I can submit a patch to change it, but wasn't sure whether it was just overlooked or if there was a reason it wasn't done.

bash-4.2$ cat /proc/fs/lustre/llite/lquake-ffff883a74d0a000/stats
snapshot_time 1530651162.784915742 secs.nsecs
bash-4.2$ touch /p/lquake/faaland1/touched
bash-4.2$ echo $?
0
bash-4.2$ cat /proc/fs/lustre/llite/lquake-ffff883a74d0a000/stats
snapshot_time 1530651198.529596878 secs.nsecs
open 1 samples [regs]
close 1 samples [regs]
readdir 2 samples [regs]
setattr 1 samples [regs]
getattr 3 samples [regs]
alloc_inode 1 samples [regs]
getxattr 7 samples [regs]
getxattr_hits 6 samples [regs]
removexattr 1 samples [regs]
inode_permission 6 samples [regs]
bash-4.2$ grep -e creat -e mknod /proc/fs/lustre/llite/lquake-ffff883a74d0a000/stats

 Comments   
Comment by Olaf Faaland [ 03/Jul/18 ]

Also, not tracked in MDC and it seems to me like they should be, so you can see which MDTs your creates are occurring on. But maybe there's a reason not to.

Comment by Peter Jones [ 04/Jul/18 ]

Emoly

Could you please look into this request?

Thanks

Peter

Comment by Olaf Faaland [ 30/Oct/19 ]

Hi, checking on this again. I'm not asking for a patch, I'm asking whether there's a technical reason this is problematic to do.

Comment by Gerrit Updater [ 06/Dec/19 ]

Olaf Faaland-LLNL (faaland1@llnl.gov) uploaded a new patch: https://review.whamcloud.com/36948
Subject: LU-11114 llite: Update mdc and lite stats on open|creat
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0fa270dbe557bd80e374514b3073163bcdaa2d87

Comment by Gerrit Updater [ 01/Feb/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36948/
Subject: LU-11114 llite: Update mdc and lite stats on open|creat
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4b8518ee4fa542f45fcdaeaec580d858dfcaf137

Comment by Peter Jones [ 01/Feb/20 ]

Landed for 2.14. ofaaland should we consider this for a future 2.12.x release too?

Comment by Olaf Faaland [ 03/Feb/20 ]

Hi Peter, yes, I think it is worth considering.  Thanks.

 

Comment by Gerrit Updater [ 07/Apr/20 ]

Olaf Faaland-LLNL (faaland1@llnl.gov) uploaded a new patch: https://review.whamcloud.com/38158
Subject: LU-11114 llite: Update mdc and lite stats on open|creat
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 1da087645f0127a5e6e911991dbb5aa84e3b8d2e

Comment by Gerrit Updater [ 14/Apr/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/38158/
Subject: LU-11114 llite: Update mdc and lite stats on open|creat
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: cccd5c79c6697906c8409e867984f73d0ae8474d

Generated at Sat Feb 10 02:41:04 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.