[#LU-1116] support rhel6.2 patchless client on 1.8.x

[LU-1116] support rhel6.2 patchless client on 1.8.x Created: 17/Feb/12 Updated: 09/May/12 Resolved: 09/May/12
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 1.8.7
Fix Version/s:	Lustre 1.8.8

Type:

Improvement

Priority:

Minor

Reporter:

Shuichi Ihara (Inactive)

Assignee:

Yang Sheng

Resolution:

Fixed

Votes:

Labels:

None

Attachments:

LU-1116-full.patch

Rank (Obsolete):

9737

Description

RHEL6.2 pathcless client needs to be supported on 1.8.x. Intel and AMD CPU based server requires rhel6.2's kernel to support full functions and performance. The master branch supports for this distribution, so at least we need backport the following patches from master branch, and one code change for the patchless client.

~~LU-766~~ Incorrect HAVE_STATFS_DENTRY_PARAM result
~~LU-778~~ RHEL 6.2: rdma_create_id() takes four arguments
~~LU-1050~~ configure broken on centos6.2 with OFED-1.5.4

On rhel6.2's kenrel, an function name roundup() in include/linux/kernel.h was changed to round_up() which is duplicated what the lustre used in lustre/mdc/mdc_locks.c.
So, we may need to change this function name like lu_round_up(). This is discussed on wc-discuss.

--- a/lustre/mdc/mdc_locks.c	2012-01-12 15:54:32.731336048 +0100
+++ b/lustre/mdc/mdc_locks.c	2012-01-12 15:54:46.072345471 +0100
@@ -185,7 +185,7 @@
         }
 }
 
-static int round_up(int val)
+static int lu_round_up(int val)
 {
         int ret = 1;
         while (val) {
@@ -301,7 +301,7 @@
         rc = lustre_msg_size(class_exp2cliimp(exp)->imp_msg_magic,
                              bufcount, size);
         if (rc & (rc - 1))
-                size[bufcount - 1] = min(size[bufcount - 1] + round_up(rc) - rc,
+                size[bufcount - 1] = min(size[bufcount - 1] + lu_round_up(rc) - rc,
                                          (__u32)obddev->u.cli.cl_max_mds_easize);
 
         /* If inode is known, cancel conflicting OPEN locks. */

Comments

Comment by Pak Lui [ 18/Feb/12 ]

I also experienced the same issue. Thanks for filing the bug report. I am using the v1_8_7_WC1.
...
make[3]: Entering directory `/usr/src/kernels/2.6.32-220.el6.x86_64'
CC [M] /root/lustre-release-1cf716f/lustre/mdc/mdc_locks.o
/root/lustre-release-1cf716f/lustre/mdc/mdc_locks.c:188:28: error: macro "round_up" requires 2 arguments, but only 1 given
/root/lustre-release-1cf716f/lustre/mdc/mdc_locks.c:189: error: expected '=', ',', ';', 'asm' or '_attribute_' before '{' token
…

Comment by Shuichi Ihara (Inactive) [ 19/Feb/12 ]

my tested a patchset of ~~LU-766~~, ~~LU-778~~, ~~LU-1050~~ and round_up() fix for b1.8 and v1_8_7_WC1.

checkout v1_8_7_WC1 branch and applied patch, then ran "sh ./autogen.sh; ./configure --enable-dist; make dist"

Comment by Kent Engström (Inactive) [ 20/Feb/12 ]

I tested building a patchless client for 2.6.32-220.4.2.el6.x86_64 (CentOS 6.2) using the ~~LU-1116~~-full.patch on top of
commit ac57d5a2 (~~LU-987~~ build: Fail to create ldisk rpms) on the b1_8 branch. Building and installing worked,
and I managed to access our Lustre servers.

Comment by Peter Jones [ 20/Feb/12 ]

Yangsheng

Could you please look into what is involved here?

Thanks

Peter