[LU-11198] “lctl get_param“ doesn't return errno when reading fails Created: 02/Aug/18  Updated: 06/Oct/18  Resolved: 06/Oct/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.12.0

Type: Bug Priority: Critical
Reporter: Li Xi Assignee: Wang Shilong (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

both 2.10 and master branch have the problem

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

The problem (Or feature? I don't think it is a good feature though) is caused by a defect in param_display(). The return failure of read_param() is ignored.

 

  1. lctl get_param -n ost.OSS.ost_io.nrs_tbf_rule
    error: get_param: reading 'ost.OSS.ost_io.nrs_tbf_rule': No such device
    ]# echo $?
    0

 Comments   
Comment by Gerrit Updater [ 02/Aug/18 ]

Wang Shilong (wshilong@ddn.com) uploaded a new patch: https://review.whamcloud.com/32925
Subject: LU-11198 utils: propagate errors for read_param
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0e0bf55db8f269dbc6c2d7856be9c7d182fed713

Comment by Gerrit Updater [ 05/Oct/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/32925/
Subject: LU-11198 utils: propagate errors for read_param
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6ca2425ccf6bf7176a37a4c93a67995479307036

Comment by Peter Jones [ 06/Oct/18 ]

Landed for 2.12

Generated at Sat Feb 10 02:41:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.