[LU-11384] wrong check in libcfs_debug_vmsg2()

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Wang Shilong (Inactive)
• Assignee: Wang Shilong (Inactive)
• Resolution: Duplicate
• Severity: 3

Description

It looks current CDEBUG_LIMIT did not work well, after some 'git blame':
Regression comes from fdb5d3d50

-        if (cdls != NULL) {
-                if (libcfs_console_ratelimit &&
-                    cdls->cdls_next != 0 &&     /* not first time ever */
-                    !cfs_time_after(cfs_time_current(), cdls->cdls_next)) {
-                        /* skipping a console message */
-                        cdls->cdls_count++;
-                        if (tcd != NULL)
-                                cfs_trace_put_tcd(tcd);
-                        return 1;
-                }
+       if (cdls != NULL) {
+               if (libcfs_console_ratelimit &&
+                   cdls->cdls_next != 0 &&     /* not first time ever */ 
+                   time_after(jiffies, cdls->cdls_next)) { ------->check logic is wrong here.
+                       /* skipping a console message */
+                       cdls->cdls_count++;
+                       if (tcd != NULL)
+                               cfs_trace_put_tcd(tcd);
+                       return 1;
+               }
 

After fixing above wrong check, problem is gone.

Issue Links

• duplicates: LU-11373 CERROR/CWARN messages are not throttled
• duplicates: LU-11383 A lot of cfs_fail_loc error message f...

Comments

[Peter Jones]

https://review.whamcloud.com/#/c/33154

[Peter Jones]

duplicate of LU-11373