[LU-11476] Account for -ECONNRESET in ksocknak_txlist_done() Created: 04/Oct/18 Updated: 29/Oct/18 Resolved: 29/Oct/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.12.0 |
| Fix Version/s: | Lustre 2.12.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Sonia Sharma (Inactive) | Assignee: | Sonia Sharma (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | lnet, lnet-health | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
In ksocknal_txlist_done(), ECONNRESET error is not accounted for. This should be added for remote failure cases.
»·······»·······if (tx->tx_hstatus == LNET_MSG_STATUS_OK) { 440 »·······»·······»·······if (error == -ETIMEDOUT) 441 »·······»·······»·······»·······tx->tx_hstatus = 442 »·······»·······»·······»······· LNET_MSG_STATUS_LOCAL_TIMEOUT; 443 »·······»·······»·······else if (error == -ENETDOWN || 444 »·······»·······»·······»······· error == -EHOSTUNREACH || 445 »·······»·······»·······»······· error == -ENETUNREACH) 446 »·······»·······»·······»·······tx->tx_hstatus = LNET_MSG_STATUS_LOCAL_DROPPED; 447 »·······»·······»·······/* 448 »·······»·······»······· * for all other errors we don't want to 449 »·······»·······»······· * retransmit 450 »·······»·······»······· */ 451 »·······»·······»·······else if (error) 452 »·······»·······»·······»·······tx->tx_hstatus = LNET_MSG_STATUS_LOCAL_ERROR; 453 »·······»·······} Accounting for ECONNRESET and updating the tx health status to LNET_MSG_STATUS_REMOTE_DROPPED corrects this behaviour. |
| Comments |
| Comment by Gerrit Updater [ 04/Oct/18 ] |
|
Patch abandoned. |
| Comment by Gerrit Updater [ 05/Oct/18 ] |
|
Amir Shehata (ashehata@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33294 |
| Comment by Gerrit Updater [ 05/Oct/18 ] |
|
Amir Shehata (ashehata@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33307 |
| Comment by Gerrit Updater [ 29/Oct/18 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33307/ |
| Comment by Peter Jones [ 29/Oct/18 ] |
|
Landed for 2.12 |