[LU-11530] lnetctl set health_sensitivity does not return error with value greater than 1000 Created: 17/Oct/18  Updated: 02/Nov/18  Resolved: 02/Nov/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.12.0
Fix Version/s: Lustre 2.12.0

Type: Bug Priority: Minor
Reporter: Jian Yu Assignee: Amir Shehata (Inactive)
Resolution: Fixed Votes: 0
Labels: None
Environment:

Lustre Build: https://build.whamcloud.com/job/lustre-master/3806/


Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Usage message for "lnetctl set health_sensitivity" is:

# lnetctl set health_sensitivity
set health_sensitivity: sensitivity to failure
        0 - turn off health evaluation
        >0 - sensitivity value not more than 1000

However, with value greater than 1000, the command can also run successfully:

# lnetctl set health_sensitivity 2048
# lnetctl global show
global:
    numa_range: 0
    max_intf: 200
    discovery: 1
    retry_count: 0
    transaction_timeout: 5
    health_sensitivity: 2048      <------------ should no more than 1000


 Comments   
Comment by Peter Jones [ 17/Oct/18 ]

Amir

Does this need to be addressed for 2.12?

Peter

Comment by Amir Shehata (Inactive) [ 17/Oct/18 ]

Yes. I'll create a patch.

Comment by Gerrit Updater [ 17/Oct/18 ]

Amir Shehata (ashehata@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33392
Subject: LU-11530 lnet: properly error check sensitivity
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a2b71c9226d2bda6b606b9d6f883f071ee9654aa

Comment by Gerrit Updater [ 02/Nov/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33392/
Subject: LU-11530 lnet: properly error check sensitivity
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a5c1cd5ec240543a3b77b5da86eaceff0ace5ba0

Comment by Peter Jones [ 02/Nov/18 ]

Landed for 2.12

Generated at Sat Feb 10 02:44:40 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.