[LU-11555] warn when mounting ZFS pools without "multihost" enabled Created: 22/Oct/18  Updated: 01/Apr/19  Resolved: 23/Jan/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.12.0, Lustre 2.10.5
Fix Version/s: Lustre 2.13.0, Lustre 2.12.1

Type: Improvement Priority: Major
Reporter: Andreas Dilger Assignee: Nathaniel Clark
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
Rank (Obsolete): 9223372036854775807

 Description   

It would be good to warn when importing a pool that does not have the multihost feature enabled, so that users are aware that their pool is exposed to potential data loss in case of double import.

Ideally, this message would only be printed in the case that the OST is configured to be multi-homed (-failnode or -servicenode configured), but it isn't clear that the configuration layer that understands peers knows the pool is ZFS and vice versa. Since we enable multihost for all new pools since 2.10.1 there will hopefully be a relatively smaller number of sites not using this feature. It is not harmful (though not useful) if it is enabled for ZFS 0.6.x, so it might be worthwhile to print a slightly different message for ZFS 0.6.x encouraging the system to be upgraded.



 Comments   
Comment by Nathaniel Clark [ 25/Oct/18 ]

There's not a good way to do that on import, but we could probably do it on mount.

Comment by Gerrit Updater [ 26/Oct/18 ]

Nathaniel Clark (nclark@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33491
Subject: LU-11555 utils: ZFS check multihost enabled in read_ldd()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5c645d5a9726f67f9fec0a9b0d4d73f8bda8bc44

Comment by Gerrit Updater [ 23/Jan/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33491/
Subject: LU-11555 utils: ZFS check multihost enabled in read_ldd()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5e62552e7fc6e9da4068bb29f62eb2cf7a42970e

Comment by Nathaniel Clark [ 23/Jan/19 ]

Should this be ported to 2.10.x and/or 2.12.x?

Comment by Andreas Dilger [ 23/Jan/19 ]

Probably good to include in 2.12.

Comment by Peter Jones [ 23/Jan/19 ]

Landed for 2.13

Comment by Gerrit Updater [ 25/Feb/19 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34300
Subject: LU-11555 utils: ZFS check multihost enabled in read_ldd()
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 5ca3ada4555390fcd8b281a3f74ab4475a04a7cd

Comment by Gerrit Updater [ 01/Apr/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34300/
Subject: LU-11555 utils: ZFS check multihost enabled in read_ldd()
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: af58b117ec0e252de641e05722768cad95bba44f

Generated at Sat Feb 10 02:44:53 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.