[LU-11558] t32_verify_quota() not being called by t32_test() Created: 22/Oct/18  Updated: 06/Jan/22  Resolved: 06/Jan/22

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.11.0, Lustre 2.12.0
Fix Version/s: Lustre 2.15.0

Type: Bug Priority: Minor
Reporter: Andreas Dilger Assignee: Andreas Dilger
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-11556 conf-sanity test 32b crashes on MDT u... Open
is related to LU-3285 Data on MDT Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Since patch https://review.whamcloud.com/28020 "LU-3285 test: add Data-on-MDT tests and fixes" landed as commit v2_10_53_0-39-ga7625cd2f3 the call to t32_verify_quota() from conf-sanity.sh t32_test() has been removed, and (I'd guess) that we are no longer verifying that quota is still working correctly after an upgrade.

It is unclear why this check was removed. It needs to be returned back to the code so that we resume testing that quota is working after an upgrade from an old disk format.

It looks like the t32_verify_quota() function itself was broken by patch https://review.whamcloud.com/30087 "LU-7004 tests: move from lctl conf_param to lctl set_param -P" which recently landed, because that is calling "set_persistent_param_and_check $node" when it should be calling "set_persistent_param_and_check $facet" (though t32_verify_quota() is not passed a facet, so I'm not yet sure what needs to be done to fix it).

 Comments   
Comment by Andreas Dilger [ 22/Oct/18 ]

This first came to light in the test_32() output from LU-11556.

Comment by Andreas Dilger [ 22/Oct/18 ]

See https://review.whamcloud.com/33422 "LU-11556 tests: fix set_persistent_param_and_check breakage" as a starting point.

Comment by Gerrit Updater [ 22/Oct/18 ]

Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33423
Subject: LU-11558 tests: re-enable conf-sanity t32_verify_quota()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9a302ca09b3e9810a43b78628c8ac5ba7b1a5eab

Comment by Andreas Dilger [ 22/Oct/18 ]

Faster to just push an add-on patch to my previous one, I leave it to you and Hongchao to debug any issues (hopefully none).

Comment by James A Simmons [ 13/Nov/18 ]

Patch landed for LU-7004 regression spot while resolving this problem so link is no longer needed.

Comment by Gerrit Updater [ 06/Jan/22 ]

"Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/33423/
Subject: LU-11558 tests: re-enable conf-sanity t32_verify_quota()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 35b9575fd02f485f48793bedd5de270b826a82b1

Comment by Peter Jones [ 06/Jan/22 ]

Landed for 2.15

Generated at Sat Feb 10 02:44:55 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.