[LU-11561] Change syncjournal back to sync_journal Created: 23/Oct/18 Updated: 15/Nov/19 Resolved: 10/Nov/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.12.0 |
| Fix Version/s: | Lustre 2.12.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | James Nunez (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | tests | ||
| Issue Links: |
|
||||||||||||
| Severity: | 3 | ||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||
| Description |
|
When we moved the ofd module from using proc to sysfs, the sync journal attribute changed from sync_journal to syncjournal; LU-8066 patch commit 7059644e9ad3eaf. obdfilter-survey and replay-single still use sync_journal: lustre/tests/obdfilter-survey.sh: $LCTL get_param obdfilter.${FSNAME}-*.sync_journal
lustre/tests/obdfilter-survey.sh: "obdfilter.${FSNAME}-*.sync_journal" > $param_file
lustre/tests/obdfilter-survey.sh: $LCTL set_param obdfilter.${FSNAME}-*.sync_journal=0
lustre/tests/obdfilter-survey.sh: $LCTL get_param obdfilter.${FSNAME}-*.sync_journal
lustre/tests/obdfilter-survey.sh: "obdfilter.${FSNAME}-*.sync_journal" > $param_file
lustre/tests/obdfilter-survey.sh: $LCTL set_param obdfilter.${FSNAME}-*.sync_journal=0
lustre/tests/replay-single.sh: do_facet ost1 "lctl set_param -n obdfilter.${ost1_svc}.sync_journal 0"
lustre/tests/replay-single.sh: do_facet ost1 "lctl set_param -n obdfilter.${ost1_svc}.sync_journal 0"
Note: This change needs to be made to the Lustre manual also: By default, sync_journal is enabled (sync_journal=1), so that journal entries are committed synchronously. To enable asynchronous journal commit, set the sync_journal parameter to 0 by entering: $ lctl set_param obdfilter.*.sync_journal=0 obdfilter.lol-OST0001.sync_journal=0 EDIT: Based on Andreas' comment below, let's move syncjournal back to sync_journal. |
| Comments |
| Comment by Andreas Dilger [ 23/Oct/18 ] |
|
This will also cause test and user interop issues. Instead of fixing the test, you should rename the /sys files to "sync_journal" again. |
| Comment by Gerrit Updater [ 05/Nov/18 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33582 |
| Comment by Gerrit Updater [ 10/Nov/18 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33582/ |
| Comment by Peter Jones [ 10/Nov/18 ] |
|
Landed for 2.12 |