[LU-11563] 99-lustre.rules on clients tries to execute non-existent /usr/sbin/l_tunedisk Created: 23/Oct/18  Updated: 06/Dec/18  Resolved: 06/Nov/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.5
Fix Version/s: Lustre 2.12.0, Lustre 2.10.6

Type: Bug Priority: Minor
Reporter: Jay Lan (Inactive) Assignee: Nathaniel Clark
Resolution: Fixed Votes: 0
Labels: None
Environment:

sles12sp3 kernel, Mellanox ofed 4.4.2, lustre client 2.10.5


Issue Links:
Related
is related to LU-9551 I/O errors when lustre uses multipath... Resolved
is related to LU-11736 Do not apply bulk IO tuning on MDT or... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Commit "LU-9551 utils: add l_tunedisk to fix disk tunings" added the following lines to 99-lustre.rules.

  1. Ensure block devices re-added to the system allow for large writes (LU-9551)
    ACTION=="add|change", SUBSYSTEM=="block", RUN+="/usr/sbin/l_tunedisk /dev/%k"

However, /usr/sbin/l_tunedisk does not exist on lustre clients and resulted in dmesg:

Oct 23 08:06:49 lmds1 systemd[1]: Started udev Coldplug all Devices.
Oct 23 08:06:49 lmds1 systemd-udevd[1565]: failed to execute '/usr/sbin/l_tunedisk' '/usr/sbin/l_tunedisk /dev/sdb': No such file or directory
Oct 23 08:06:49 lmds1 systemd-udevd[1161]: Process '/usr/sbin/l_tunedisk /dev/sdb' failed with exit code 2.

Isn't this supposed to be on the server side only?



 Comments   
Comment by Peter Jones [ 23/Oct/18 ]

Nathaniel

Could you please advise?

Thanks

Peter

Comment by Nathaniel Clark [ 24/Oct/18 ]

It should be server side only.  I'll post a patch to fix.

Comment by Gerrit Updater [ 24/Oct/18 ]

Nathaniel Clark (nclark@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33466
Subject: LU-11563 build: Only add l_tunedisk udev rule to server
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2ac46159f3f307ca79c27188991ad0ee9ea6ca10

Comment by Jay Lan (Inactive) [ 26/Oct/18 ]

Could you also back port to b2_10? Thanks.

Comment by Peter Jones [ 26/Oct/18 ]

Jay

It'll be back ported after it has landed to master

Peter

Comment by Gerrit Updater [ 06/Nov/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33466/
Subject: LU-11563 build: Only add l_tunedisk udev rule to server
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0d11a314787bc795797a016262e9bcfe86e2193e

Comment by Peter Jones [ 06/Nov/18 ]

Landed for 2.12

Comment by Karsten Weiss [ 20/Nov/18 ]

Please also backport to b2_10 for v2_10_6-RC2.

(I just ran into this issue on my first CentOS 7.6 Lustre client test system using 2.10.6-RC1-6-g9a6262c8ff.)

Comment by Gerrit Updater [ 20/Nov/18 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33688
Subject: LU-11563 build: Only add l_tunedisk udev rule to server
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 2fa7c433d94af1e1f6b96f687ba57a1cf11085fc

Comment by Gerrit Updater [ 22/Nov/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33688/
Subject: LU-11563 build: Only add l_tunedisk udev rule to server
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 62e5817dcbdb249e1779cbc0d139b0247d14bed7

Generated at Sat Feb 10 02:44:58 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.