[LU-11568] Get rid of SLAB_DESTROY_BY_RCU Created: 25/Oct/18  Updated: 20/Jun/19  Resolved: 06/Feb/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.13.0
Fix Version/s: Lustre 2.13.0, Lustre 2.12.1

Type: Bug Priority: Critical
Reporter: Oleg Drokin Assignee: Oleg Drokin
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
Related
is related to LU-11063 RHEL7.[345] RCU breakage Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

This code was introduced by bz 18015 https://bugzilla.lustre.org/show_bug.cgi?id=18015

Newer kernels rename that symbol and it's not used anyway, but also at least in RHEL 7.[345] there's bug in this functionality htat leads to use after frees that are seen prominently in our nfs testing in maloo (in addition to my testrig). See LU-11063.
Example nfs failures:
https://testing.whamcloud.com/test_sessions/1cd5592c-8319-4aa7-aa2b-4549a83ce9cd
https://testing.whamcloud.com/test_sessions/9e6c8dec-d1dd-4ad4-b028-f98b5fdf63a9

Anyway after reviewing the original patch I think we just need to get rid of this flag altogether and if the rapid load/unload is still a problem, work it around in some better more robust way.



 Comments   
Comment by Gerrit Updater [ 31/Jan/19 ]

Oleg Drokin (green@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34147
Subject: LU-11568 ldlm: Remove use of SLAB_DESTROY_BY_RCU for ldlm lock slab
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 07d0c94f6a6c7b86cd7e738d368cfbcbff3f42b5

Comment by Gerrit Updater [ 06/Feb/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34147/
Subject: LU-11568 ldlm: Remove use of SLAB_DESTROY_BY_RCU for ldlm lock slab
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 82d014e71e14671e876055851a0d37e98b4cc079

Comment by Peter Jones [ 06/Feb/19 ]

Landed for 2.13

Comment by Gerrit Updater [ 16/Mar/19 ]

Oleg Drokin (green@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34434
Subject: LU-11568 ldlm: Remove use of SLAB_DESTROY_BY_RCU for ldlm lock slab
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 2f34a93ec495254cb69a00d58e9b53c96be86054

Comment by Gerrit Updater [ 19/Mar/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34434/
Subject: LU-11568 ldlm: Remove use of SLAB_DESTROY_BY_RCU for ldlm lock slab
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: f60637d9379df8c1e9aabf2f8639e8e318489a4d

Comment by Gerrit Updater [ 31/May/19 ]

Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35018
Subject: LU-11568 ldlm: Remove use of SLAB_DESTROY_BY_RCU for ldlm lock slab
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 537c25bbd9a90a198ab464ec2fd67d29b7cbe591

Generated at Sat Feb 10 02:45:00 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.