[LU-11607] Reduce repeated function calls in Lustre test suites Created: 02/Nov/18 Updated: 17/Feb/21 Resolved: 17/Feb/21 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.12.0 |
| Fix Version/s: | Lustre 2.14.0 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | James Nunez (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | easy, tests | ||
| Issue Links: |
|
||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
There are many repeated calls to the same function with the same input in each of the Lustre test suites. One example of this is the call to Let's get the environment variables that are stable during each test suite in a routine, call it at the beginning of each test suite and export it for the test suites to use. The routine must be called after we source the configuration file
. $LUSTRE/tests/test-framework.sh
init_test_env $@
. ${CONFIG:=$LUSTRE/tests/cfg/$NAME.sh}
since SINGLEMDS and other variables are defined in the configuration file. The patch for Please list any other test suite routine calls that can be reduced in this way. |
| Comments |
| Comment by Gerrit Updater [ 28/Dec/18 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33938 |
| Comment by Gerrit Updater [ 24/Jan/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33938/ |
| Comment by James A Simmons [ 25/Jan/19 ] |
|
I'm seeing: ---- |
| Comment by James Nunez (Inactive) [ 25/Jan/19 ] |
|
James - a couple of patches were landed out of order. The error that you reported should be cleaned up now. Please rebase any patches that are in flight. |
| Comment by Andreas Dilger [ 27/Jan/19 ] |
|
Janes N, it makes sense to push out a patch that removes usage of SINGLEMDS, but leaves the definition of SINGLEMDS in test-framework.sh for a few weeks in case it is used in another patch in flight. They can both be submitted at the same time, but mark the second one -1 until we are ready to land it. |
| Comment by Gerrit Updater [ 25/Feb/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34319 |
| Comment by Gerrit Updater [ 01/Apr/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34319/ |
| Comment by James Nunez (Inactive) [ 23/Apr/19 ] |
|
With the landing of https://review.whamcloud.com/33611/, get_lustre_env() was moved into init_logging() in test-framework.sh and, thus, is available to all test scripts from Lustre 2.12.53 on. We've already cleaned up sanity.sh by replacing calls to lustre_version_code() with MGS_VERSION, MDS1_VERSION or CLIENT_VERSION and replacing facet_fstype() with mds1_FSTYPE or ost1_FSTYPE. What's left to do for this ticket is to replace these calls in all the other Lustre test suites. |
| Comment by Gerrit Updater [ 07/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35719 |
| Comment by Gerrit Updater [ 07/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35721 |
| Comment by Gerrit Updater [ 07/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35723 |
| Comment by Gerrit Updater [ 07/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35724 |
| Comment by Gerrit Updater [ 10/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35760 |
| Comment by Gerrit Updater [ 11/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35766 |
| Comment by Gerrit Updater [ 15/Aug/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35721/ |
| Comment by Gerrit Updater [ 26/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35928 |
| Comment by Gerrit Updater [ 26/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35929 |
| Comment by Gerrit Updater [ 27/Aug/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35934 |
| Comment by Gerrit Updater [ 03/Sep/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35724/ |
| Comment by Gerrit Updater [ 06/Sep/19 ] |
|
Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36093 |
| Comment by Gerrit Updater [ 07/Sep/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35760/ |
| Comment by Gerrit Updater [ 07/Sep/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35766/ |
| Comment by Gerrit Updater [ 16/Sep/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35723/ |
| Comment by Gerrit Updater [ 16/Sep/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36093/ |
| Comment by Gerrit Updater [ 04/Oct/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35934/ |
| Comment by Gerrit Updater [ 04/Oct/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36375 |
| Comment by Gerrit Updater [ 04/Oct/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36380 |
| Comment by Gerrit Updater [ 27/Oct/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36380/ |
| Comment by Gerrit Updater [ 12/Nov/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35928/ |
| Comment by Gerrit Updater [ 05/Dec/19 ] |
|
Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36942 |
| Comment by Gerrit Updater [ 09/Dec/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36965 |
| Comment by Gerrit Updater [ 14/Dec/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36375/ |
| Comment by Gerrit Updater [ 20/Dec/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36965/ |
| Comment by Gerrit Updater [ 08/Feb/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35719/ |
| Comment by Gerrit Updater [ 25/Feb/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36942/ |
| Comment by Gerrit Updater [ 20/Oct/20 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/40313 |
| Comment by Gerrit Updater [ 08/Feb/21 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35929/ |
| Comment by Peter Jones [ 17/Feb/21 ] |
|
Looks like everything has landed for 2.14 |