[LU-11611] Incorrect return value in mdt_reint_unlink Created: 03/Nov/18  Updated: 10/Nov/18  Resolved: 10/Nov/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.12.0
Fix Version/s: Lustre 2.12.0

Type: Bug Priority: Major
Reporter: Oleg Drokin Assignee: Lai Siyao
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-4684 DNE3: allow migrating DNE striped dir... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Added by recent landing of https://review.whamcloud.com/31425

        /* We will lock the child regardless it is local or remote. No harm. */
        mc = mdt_object_find(info->mti_env, info->mti_mdt, child_fid);
        if (IS_ERR(mc))
                GOTO(unlock_parent, rc = PTR_ERR(mc));

        if (!cos_incompat) {
                rc = mdt_object_striped(info, mc);
                if (rc < 0)
                        GOTO(unlock_parent, rc = PTR_ERR(mc));

this last PTR_ERR should clearly be just "rc".



 Comments   
Comment by Peter Jones [ 03/Nov/18 ]

Lai

 

Could you please investigate?

 

Thanks

 

Peter

Comment by Lai Siyao [ 05/Nov/18 ]

I'll give a fix soon.

Comment by Gerrit Updater [ 05/Nov/18 ]

Lai Siyao (lai.siyao@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33577
Subject: LU-11611 mdt: incorrect return value in mdt_reint_unlink
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 43fdc8e75d12a2fe461913f4310cefa4b842ded2

Comment by Gerrit Updater [ 10/Nov/18 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33577/
Subject: LU-11611 mdt: incorrect return value in mdt_reint_unlink
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 03f077a5dbcd9c4096c6f6ff1bf12b8f39a16603

Comment by Peter Jones [ 10/Nov/18 ]

Landed for 2.12

Generated at Sat Feb 10 02:45:23 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.