[LU-1163] Never try to invalidate a dirty page Created: 02/Mar/12  Updated: 02/May/12  Resolved: 04/Mar/12

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.2.0
Fix Version/s: Lustre 2.2.0

Type: Bug Priority: Blocker
Reporter: Jinshan Xiong (Inactive) Assignee: Jinshan Xiong (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 4700

 Description   

in ll_page_mkwrite(), the page is wrongly invalidated w/o checking if it's dirty. This will cause data corruption if this page contains useful data. We should write it back before invalidating it. This is the wrong:

 Comments   
Comment by Jinshan Xiong (Inactive) [ 02/Mar/12 ]

Patch is at: http://review.whamcloud.com/2243

Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,client,el5,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,client,el6,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,server,el5,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,client,el5,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,server,el5,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,server,el6,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,server,el6,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,client,el6,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,client,el5,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,server,el5,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,client,el6,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 04/Mar/12 ]

Integrated in lustre-master » i686,server,el6,ofa #501
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Peter Jones [ 04/Mar/12 ]

Landed for 2.2

Comment by Christopher Morrone [ 12/Apr/12 ]

What about 2.1? This sounds like it causes data corruption when it hits, so it should be on the short list for landing on b2_1 if it is applicable.

Comment by Peter Jones [ 12/Apr/12 ]

Chris this issue was only introduced by the fix for LU844 so is not relevant for b2_1

Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,client,el5,inkernel #340
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,client,el6,inkernel #340
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,server,el5,inkernel #340
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/tests/sanity.sh
  • lustre/llite/llite_mmap.c
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,server,el6,inkernel #340
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,client,el5,inkernel #340
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,server,el5,inkernel #340
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,client,el6,inkernel #340
LU-1163 llite: never try to invalidate a dirty page (Revision fdeace7e542360989645ea3dd9954a5f28c681aa)

Result = SUCCESS
Oleg Drokin : fdeace7e542360989645ea3dd9954a5f28c681aa
Files :

  • lustre/llite/llite_mmap.c
  • lustre/tests/sanity.sh
Generated at Sat Feb 10 01:14:06 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.