[LU-11675]  Don't allow new HSM requests during CDT_INIT Created: 16/Nov/18  Updated: 17/Jun/20  Resolved: 07/Sep/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.11.0
Fix Version/s: Lustre 2.13.0, Lustre 2.12.3

Type: Bug Priority: Major
Reporter: Nikitas Angelinas Assignee: Nikitas Angelinas
Resolution: Fixed Votes: 0
Labels: patch

Issue Links:
Duplicate
Related
is related to LU-13689 Replace cdt_state_lock with cdt_llog_... Open
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

When the HSM CDT is shut down and restarted, it resets cdt_last_cookie using ktime_get_real_seconds() and examines the CDT llog for existing requests, in order to set cdt_last_cookie to the highest known value, so that newly-assigned cookies are unique. There is a window between CDT_INIT and CDT_RUNNING during which new requests can arrive, and if the CDT llog has not been fully examined, cookies can be reused. This can cause the following two assertions to be triggered in cdt_agent_record_hash_add():

LASSERT(carl0->carl_cat_idx == carl1->carl_cat_idx);
LASSERT(carl0->carl_rec_idx == carl1->carl_rec_idx);



 Comments   
Comment by Gerrit Updater [ 16/Nov/18 ]

Nikitas Angelinas (nangelinas@cray.com) uploaded a new patch: https://review.whamcloud.com/33671
Subject: LU-11675 hsm: don't allow new HSM requests during CDT_INIT
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 334d938ab8c2c94b0a866adfaa00902e4756d8c0

Comment by Gerrit Updater [ 07/Sep/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33671/
Subject: LU-11675 hsm: don't allow new HSM requests during CDT_INIT
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 39862136c3cfee127c4b0a9604ff12f560af3124

Comment by Peter Jones [ 07/Sep/19 ]

Landed for 2.13

Comment by Gerrit Updater [ 17/Sep/19 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36212
Subject: LU-11675 hsm: don't allow new HSM requests during CDT_INIT
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 8b3ea9b827b413fa8535d4748d3035f63b8d8a7a

Comment by Gerrit Updater [ 23/Sep/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36212/
Subject: LU-11675 hsm: don't allow new HSM requests during CDT_INIT
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: b6ca2afe07966cb536a77adf83001fb328de4bb0

Generated at Sat Feb 10 02:45:57 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.