[LU-11796] Remove LASSERT(r0->lo_nr <= lov_targets_nr(dev)) in maintenance branches Created: 17/Dec/18  Updated: 08/Jun/19  Resolved: 30/Apr/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.12.0, Lustre 2.10.6
Fix Version/s: Lustre 2.13.0, Lustre 2.12.3

Type: Bug Priority: Minor
Reporter: Patrick Farrell (Inactive) Assignee: Patrick Farrell (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In reviewing the overstriping patch, Andreas noted that one assert it's removing should also be removed in the maintenance branches:

https://review.whamcloud.com/#/c/28425/15/lustre/lov/lov_object.c

This is because the client is asserting on network data from the server, and the assert is enforcing an expected constraint (num stripes <= num osts), but nothing goes wrong if it's removed.  In fact, it might be possible for the two to disagree if OSTs go offline.



 Comments   
Comment by Gerrit Updater [ 17/Dec/18 ]

Patrick Farrell (paf@cray.com) uploaded a new patch: https://review.whamcloud.com/33882
Subject: LU-11796 lov: Remove unnecessary assert
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 39e110caac0f72505c962615c5f561316e2e35bc

Comment by Gerrit Updater [ 30/Apr/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33882/
Subject: LU-11796 lov: Remove unnecessary assert
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 1d71044851192ee36f0841b525d3df0e3b054794

Comment by Peter Jones [ 30/Apr/19 ]

Landed for 2.13

Comment by Gerrit Updater [ 21/May/19 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34918
Subject: LU-11796 lov: Remove unnecessary assert
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 9560a93dac848fa6afa758bcd377cb9d5b519da0

Comment by Gerrit Updater [ 08/Jun/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34918/
Subject: LU-11796 lov: Remove unnecessary assert
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 7f9393e1ea280f45b8400f5da2cbe41a3b908872

Generated at Sat Feb 10 02:47:00 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.