Ubuntu18.10 and the beta version of the most beloved distro 
[LU-11838] Support linux kernel version 4.18 Created: 07/Jan/19 Updated: 17/Mar/20 Resolved: 27/Jun/19 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.13.0 |
| Fix Version/s: | Lustre 2.13.0, Lustre 2.12.3 |
| Type: | Improvement | Priority: | Minor |
| Reporter: | James A Simmons | Assignee: | James A Simmons |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Environment: |
Ubuntu18.10 and the beta version of the most beloved distro |
||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||||||||||||||||||||||
| Description |
|
Linux distributions are looking to move their platforms to the 4.18 kernel which was originally the LTS for the linux kernel (that has changed to 4.19). This ticket covers the work needed to support this kernel version. |
| Comments |
| Comment by Gerrit Updater [ 07/Jan/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33963 |
| Comment by James A Simmons [ 07/Jan/19 ] |
|
I ported the LNet changes from upstream. I'm testing to make sure they correctly ported. |
| Comment by Gerrit Updater [ 07/Jan/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33966 |
| Comment by Gerrit Updater [ 07/Jan/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33967 |
| Comment by Gerrit Updater [ 07/Jan/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33968 |
| Comment by Gerrit Updater [ 07/Jan/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33969 |
| Comment by Gerrit Updater [ 07/Jan/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33970 |
| Comment by Gerrit Updater [ 08/Jan/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/33984 |
| Comment by Gerrit Updater [ 16/Jan/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33984/ |
| Comment by Gerrit Updater [ 23/Jan/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33963/ |
| Comment by Gerrit Updater [ 23/Jan/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33969/ |
| Comment by Gerrit Updater [ 30/Jan/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33970/ |
| Comment by Gerrit Updater [ 11/Feb/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33966/ |
| Comment by Gerrit Updater [ 12/Feb/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/34234 |
| Comment by Peter Jones [ 12/Feb/19 ] |
|
James Any more patches to come for 4.18 support? Peter |
| Comment by James A Simmons [ 12/Feb/19 ] |
|
The changes need to be address are: LNet: kernel_getpeername() and kernel_getsockname() dropped last argument. The struct address_mapping changed from radix to xarry. All llite changes. Initialize "struct dentry_operations" .d_init using ll_d_init(). For proper parallel lookup support. Remove LASSERT(atomic_read(&lli->lli_posix_acl->a_refcount) == 1); That will do it. |
| Comment by Gerrit Updater [ 13/Feb/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/34236 |
| Comment by Gerrit Updater [ 27/Feb/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34236/ |
| Comment by Dongyang Li [ 07/Mar/19 ] |
|
James, are you working on the ldiskfs support for 4.18? If not I have a ldiskfs patchset for centos8 beta, will send it under this ticket later. Cheers DY |
| Comment by James A Simmons [ 07/Mar/19 ] |
|
No I haven't started ldiskfs support. Only clibet so far. Please push the work. |
| Comment by Chris Horn [ 27/Mar/19 ] |
|
The patch https://review.whamcloud.com/33969 seems to have broken ip2nets parsing. I'm not sure if this is the same issue documented in sles15c01:~ # ip addr show dev eth0
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
link/ether 00:0c:29:88:48:01 brd ff:ff:ff:ff:ff:ff
inet 192.168.2.22/16 brd 192.168.255.255 scope global eth0
valid_lft forever preferred_lft forever
inet6 fe80::20c:29ff:fe88:4801/64 scope link
valid_lft forever preferred_lft forever
sles15c01:~ # cat /etc/modprobe.d/lnet.conf
options lnet ip2nets="tcp99(eth0) 192.168.*.*; tcp4(eth0) 192.168.*.*"
options lnet routes="tcp 192.168.2.26@tcp4"
options lnet lnet_peer_discovery_disabled=0
#options lnet check_routers_before_use=1
sles15c01:~ # modprobe lnet
sles15c01:~ # lnetctl lnet configure --all
configure:
- lnet:
errno: -22
descr: "LNet configure error: Invalid argument"
sles15c01:~ # dmesg | tail --lines 2
[14219.235056] LNetError: 11a-a: ip2nets does not match any local IP interfaces
[14219.237168] LNetError: 3884:0:(config.c:597:lnet_parse_networks()) networks string is undefined
sles15c01:~ #
If I revert https://review.whamcloud.com/33969 then I'm able to start LNet with the above configuration. |
| Comment by James A Simmons [ 27/Mar/19 ] |
|
Chris their are two patches to address the bug. So for proper 4.18 kernel support you need 3 patches for LNet. https://review.whamcloud.com/#/c/34476/ https://review.whamcloud.com/#/c/34392/ https://review.whamcloud.com/#/c/34234 I can add you as a reviewer. |
| Comment by James A Simmons [ 27/Mar/19 ] |
|
@Dongyang Li - The patch for |
| Comment by Chris Horn [ 27/Mar/19 ] |
|
James, I hit the same issue with those three patches applied |
| Comment by James A Simmons [ 05/Apr/19 ] |
|
Chris I have a patch to fix the ip2net handling as well. I need the above patches to land first. The idea is to replace all the LND ipv4 handling by using lnet_ipaddr_enumerate() in config.c |
| Comment by Gerrit Updater [ 16/Apr/19 ] |
|
Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/34672 |
| Comment by Gerrit Updater [ 16/Apr/19 ] |
|
Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/34673 |
| Comment by Gerrit Updater [ 16/Apr/19 ] |
|
Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/34674 |
| Comment by Gerrit Updater [ 16/Apr/19 ] |
|
Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/34675 |
| Comment by Gerrit Updater [ 16/Apr/19 ] |
|
Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/34676 |
| Comment by Gerrit Updater [ 16/Apr/19 ] |
|
Li Dongyang (dongyangli@ddn.com) uploaded a new patch: https://review.whamcloud.com/34677 |
| Comment by Gerrit Updater [ 16/Apr/19 ] |
|
James Simmons (uja.ornl@yahoo.com) uploaded a new patch: https://review.whamcloud.com/34689 |
| Comment by Gerrit Updater [ 10/May/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34672/ |
| Comment by Jian Yu [ 17/May/19 ] |
|
Hi James and Dongyang, In file included from /root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.c:40:
/root/lustre-release/lnet/klnds/o2iblnd/o2iblnd.h:69:10: fatal error: linux/pci-dma.h: No such file or directory
#include <linux/pci-dma.h>
^~~~~~~~~~~~~~~~~
compilation terminated.
/root/lustre-release/lnet/lnet/lib-socket.c: In function ‘lnet_sock_ioctl’:
/root/lustre-release/lnet/lnet/lib-socket.c:76:8: error: implicit declaration of function ‘kernel_sock_ioctl’; did you mean ‘lnet_sock_ioctl’? [-Werror=implicit-function-declaration]
rc = kernel_sock_ioctl(sock, cmd, arg);
^~~~~~~~~~~~~~~~~
lnet_sock_ioctl
|
| Comment by Dongyang Li [ 17/May/19 ] |
|
Jian, for the first one you need the patch from and you need other patches from this ticket for the second compile error: https://review.whamcloud.com/#/c/33967/ https://review.whamcloud.com/#/c/33968/ https://review.whamcloud.com/#/c/34234/ note they are still under review |
| Comment by Jian Yu [ 17/May/19 ] |
|
Thank you, Dongyang. |
| Comment by James A Simmons [ 18/May/19 ] |
|
Patch 33967 is a fix which is not a hard requirement for RHEL8 support. It should be That is for building. I suspect you will need the patch from When it comes to testing I suspect the ARM test we see disabled in testing also be an issue for RHEL8. Lastly the "lustre/.fid" handling no longer works properly with newer kernels. You can see info at |
| Comment by Gerrit Updater [ 21/May/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34676/ |
| Comment by Gerrit Updater [ 21/May/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34677/ |
| Comment by Gerrit Updater [ 25/May/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34673/ |
| Comment by Gerrit Updater [ 29/May/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34234/ |
| Comment by James A Simmons [ 29/May/19 ] |
|
I think we have enough for RHEL8 client support. Still need a few patches for server support. |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35156 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35158 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35160 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35166 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35169 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35170 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35171 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35172 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35173 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35174 |
| Comment by Gerrit Updater [ 11/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35175 |
| Comment by Gerrit Updater [ 13/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34674/ |
| Comment by Gerrit Updater [ 13/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34675/ |
| Comment by Gerrit Updater [ 17/Jun/19 ] |
|
Jian Yu (yujian@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35247 |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34689/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35169/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35171/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35166/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35172/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35173/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35174/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35175/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35156/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35160/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35170/ |
| Comment by Gerrit Updater [ 27/Jun/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35158/ |
| Comment by James A Simmons [ 27/Jun/19 ] |
|
All landed. |
| Comment by Peter Jones [ 27/Jun/19 ] |
|
Except for https://review.whamcloud.com/#/c/33967/ which you are going to switch to |
| Comment by James A Simmons [ 27/Jun/19 ] |
|
Yes. I'm getting ready to rebase it. |
| Comment by Gerrit Updater [ 03/Jul/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35247/ |
| Comment by Gerrit Updater [ 11/Jul/19 ] |
|
Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35474 |
| Comment by Malcolm Haak - NCI (Inactive) [ 03/Oct/19 ] |
|
Can we please get the server commits backported to b2_12 as well? (Or at least a list of which commits to cherry pick) Currently I'm doing a couple obvious cherry-picks to get it building but I'd prefer not to be. |
| Comment by James A Simmons [ 03/Oct/19 ] |
|
I think everything required for 4.18 support has landed to the latest 2.12 LTS. |
| Comment by Malcolm Haak - NCI (Inactive) [ 16/Mar/20 ] |
|
James, I'm looking at 2.12.4 and I can see that is not correct. I have 2.12 client but not server. |
| Comment by Jian Yu [ 17/Mar/20 ] |
|
Hi Malcolm, |
| Comment by Malcolm Haak - NCI (Inactive) [ 17/Mar/20 ] |
|
Hi Jian, I think that list is missing a patch for 8.1 support (with the latest 8.1 kernel). I just finished doing what I thought were the required back ports (well enough to get it compile anyway. I am about to start testing tomorrow) This is my full list: https://review.whamcloud.com/35023 (8.1 latest kernel won't build Ldiskfs without this one) I don't have these two and reading them I probably want them. If there is anything else you think I could use please let me know. Thanks. |