[LU-11839] iokit-gather-stats help message woks with ‘-h’ or ‘--help’ not ‘-help’ Created: 07/Jan/19  Updated: 09/Jun/21  Resolved: 09/Jun/21

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.12.0, Lustre 2.13.0
Fix Version/s: Lustre 2.15.0

Type: Improvement Priority: Minor
Reporter: James Nunez (Inactive) Assignee: Arshad Hussain
Resolution: Fixed Votes: 0
Labels: easy

Rank (Obsolete): 9223372036854775807

 Description   

Running iokit-gather-stats with no flags results in

#  /usr/bin/iokit-gather-stats
Usage: iokit-gather-stats [-help] config_file [start|stop|cleanup] <log_name>

So, to get help on the command, we should use the ‘-help’ flag

#  /usr/bin/iokit-gather-stats -help
getopt: invalid option -- 'e'
getopt: invalid option -- 'l'
getopt: invalid option -- 'p'
Usage: iokit-gather-stats [-help] config_file [start|stop|cleanup] <log_name>

Well, that didn’t help.

Looking at the code, we should really use ‘h’ or ‘-help’. Thus, we should modify the Usage statement above.



 Comments   
Comment by Gerrit Updater [ 25/Mar/21 ]

Arshad Hussain (arshad.hussain@aeoncomputing.com) uploaded a new patch: https://review.whamcloud.com/43114
Subject: LU-11839 iokit: Fix help message
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c58ef43f90f63cdfbb2f41db0d4a65c202b24861

Comment by Gerrit Updater [ 08/Jun/21 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43114/
Subject: LU-11839 iokit: Fix help message
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b8ef80984140201bb4b994ee745757f07ad5f832

Comment by Peter Jones [ 09/Jun/21 ]

Landed for 2.15

Generated at Sat Feb 10 02:47:23 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.