[LU-1187] DNE Phase 1: Remote Directories Created: 05/Mar/12 Updated: 14/Apr/18 Resolved: 29/May/17 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.4.0 |
| Fix Version/s: | Lustre 2.4.0 |
| Type: | Epic | Priority: | Minor |
| Reporter: | Richard Henwood (Inactive) | Assignee: | Lai Siyao |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Sub-Tasks: |
|
||||||||||||||||||||||||||||||||||||||||||||
| Epic Name: | DNE Phase 1 | ||||||||||||||||||||||||||||||||||||||||||||
| Rank (Obsolete): | 3974 | ||||||||||||||||||||||||||||||||||||||||||||
| Description |
| Comments |
| Comment by Di Wang [ 26/Feb/13 ] |
|
Test plan for DNE phaseI |
| Comment by Alexey Lyashkov [ 20/Dec/13 ] |
|
I like to see intel land a patches without good compatibility code. + /* Note: We have to match both LOOKUP and PERM lock + * here to make sure the dentry is valid and no one + * changing the permission. + * But if the client connects < 2.4 server, which will + * only grant LOOKUP lock, so we can only Match LOOKUP + * lock for old server */ + if (exp_connect_flags(ll_i2mdexp(de->d_inode)) && + OBD_CONNECT_LVB_TYPE) + matched_bits = + MDS_INODELOCK_LOOKUP | MDS_INODELOCK_PERM; + else + matched_bits = MDS_INODELOCK_LOOKUP; why you check a connect_LVB it's don't related and very different feature? if you want you must check an osd_ibits_know or introduce a new connect flag. @@ -3565,10 +3569,11 @@ static int mdt_intent_getattr(enum mdt_it_code opcode, switch (opcode) { case MDT_IT_LOOKUP: - child_bits = MDS_INODELOCK_LOOKUP; + child_bits = MDS_INODELOCK_LOOKUP | MDS_INODELOCK_PERM; break; case MDT_IT_GETATTR: - child_bits = MDS_INODELOCK_LOOKUP | MDS_INODELOCK_UPDATE; + child_bits = MDS_INODELOCK_LOOKUP | MDS_INODELOCK_UPDATE | + MDS_INODELOCK_PERM; break; default: you should be don't send an ibits don't supported by client to him, because it's may confuse client code in some case. patch also have many spaces at end of line, but it's don't block a landing the patch. |
| Comment by Gerrit Updater [ 20/Mar/18 ] |
|
Andreas Dilger (andreas.dilger@intel.com) uploaded a new patch: https://review.whamcloud.com/31700 |
| Comment by Gerrit Updater [ 14/Apr/18 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31700/ |