[LU-11898] libcfs module parameter libcfs_debug_mb has no effect Created: 29/Jan/19  Updated: 21/Mar/19  Resolved: 21/Mar/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.13.0

Type: Bug Priority: Minor
Reporter: Vladimir Saveliev Assignee: Vladimir Saveliev
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-8066 Move lustre procfs handling to sysfs ... Open
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

debug_mb is libcfs module parameter. It should be possible to set it
via

modprobe libcfs libcfs_debug_mb=800

or via adding

options libcfs libcfs_debug_mb=800

to modules configuration.

libcfs_debug_init, however, calculated libcfs_debug_mb unconditionally, so that the module parameter makes no effect:

int libcfs_debug_init(unsigned long bufsize)
...
        libcfs_debug_mb = cfs_trace_get_debug_mb();
...


 Comments   
Comment by Gerrit Updater [ 29/Jan/19 ]

Vladimir Saveliev (c17830@cray.com) uploaded a new patch: https://review.whamcloud.com/34128
Subject: LU-11898 libcfs: do not calculate debug_mb if it is set
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e657421403664919848b0c72eb50edbe4bd7a62c

Comment by James A Simmons [ 29/Jan/19 ]

Are you seeing the module value modified or completely ignored. In my testing I see a modified value of debug_mb.

Comment by Gerrit Updater [ 21/Mar/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34128/
Subject: LU-11898 libcfs: do not calculate debug_mb if it is set
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: adeb29400a4a6466e45cb8c793500ae6d37ed642

Comment by Peter Jones [ 21/Mar/19 ]

Landed for 2.13

Generated at Sat Feb 10 02:47:53 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.