[LU-11919] cl_max_dirty_pages not zeroed on startup Created: 04/Feb/19 Updated: 08/Apr/19 Resolved: 19/Feb/19 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.13.0, Lustre 2.12.1 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Patrick Farrell (Inactive) | Assignee: | Patrick Farrell (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||
| Severity: | 3 | ||||
| Rank (Obsolete): | 9223372036854775807 | ||||
| Description |
|
cl_dirty_max_pages (the internal representation of max_dirty_mb) is not zeroed at initialization. The function client_adjust_max_dirty is called, but it only sets it if the value is <= 0, which will be true most of the time for random memory... But not all of the time. So sometimes cl_max_dirty_pages ends up at some random positive value. Easy fix. |
| Comments |
| Comment by Patrick Farrell (Inactive) [ 04/Feb/19 ] |
|
This is the issue causing the odd max_dirty_mb values. (The grant request issue is separate and should still be fixed with that patch.) |
| Comment by Gerrit Updater [ 04/Feb/19 ] |
|
Patrick Farrell (pfarrell@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34173 |
| Comment by Gerrit Updater [ 18/Feb/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34173/ |
| Comment by Peter Jones [ 19/Feb/19 ] |
|
Landed for 2.13 |
| Comment by Gerrit Updater [ 19/Mar/19 ] |
|
Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34458 |
| Comment by Gerrit Updater [ 08/Apr/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34458/ |