[LU-11924] Combine cancellation of llog records at osp_sync_process_committed

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.13.0
• Type: Improvement
• Priority: Minor
• Reporter: Alexander Boyko
• Assignee: Alexander Boyko
• Resolution: Fixed
• Labels: patch

Description

osp_sync_process_committed() takes list of osp_job_req_args and cancels llog records one by one. In most cases these records belongs to the same llog file, so they can be canceled together at single call to open/transaction/changing bitmap/disk write...
It could increase a performance.

Issue Links

• is related to: LU-11896 Memory leak occurs when lfs mkdir fails

Comments

[Gerrit Updater]

Alexandr Boyko ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34179
Subject: LU-11924 osp: combine llog cancel operations
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1c827535c555683fd6237c8750e0c15a20dcadf2

[Alexander Boyko]

I've tested the difference of osp_sync_process_commit time locally  with ftrace using test 106 conf-sanity which do createmany/unlinkmany operations. 

echo osp_sync_process_committed > set_ftrace_filter
echo 1 > function_profile_enabled

Without patch

  Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed          119433    320932.0 us     2.687 us        46349.58 us
  Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed          113400    289397.6 us     2.552 us        44790.63 us
  Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed          106545    447368.3 us     4.198 us        102860.1 us
  Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed           65637    235872.5 us     3.593 us        61195.10 us

And with patch

Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed           98916    143369.9 us     1.449 us        28541.24 us
  Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed          103008    214585.1 us     2.083 us        26861.06 us
  Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed           88466    145561.5 us     1.645 us        11074.07 us
  Function                               Hit    Time            Avg             s^2
  --------                               ---    ----            ---             ---
  osp_sync_process_committed           81857    85347.70 us     1.042 us        11470.52 us

The testing shows that average time is less for the patched version.

 

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34179/
Subject: LU-11924 osp: combine llog cancel operations
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6d733210206561f73b5c29126b4012cd7a8c0d18

[Peter Jones]

Landed for 2.13