[LU-11930] sbi_flags printing broke Created: 05/Feb/19 Updated: 29/Oct/19 Resolved: 30/Apr/19 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.13.0 |
| Fix Version/s: | Lustre 2.13.0, Lustre 2.12.1 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Oleg Drokin | Assignee: | Patrick Farrell (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
Nowadays if we do get_param on lustre-....sbi_flags we get back: error: get_param: reading 'llite.lustre-ffff88009a0ca800.sbi_flags': Invalid argument and then in the kernel [ 788.311079] LustreError: 10351:0:(lproc_llite.c:967:ll_sbi_flags_seq_show()) lustre: Revise array LL_SBI_FLAGS to match sbi flags please. The result is of course every test that checks feature flags is now not finding anything it's looking for and skips. in particular al layoutswaps (test 184*) and a bunch of other stuff is now in perma-skip mode. This was broken in Also I think we ned to convert that error message into an assertion. Problems like here we'd catch sooner and if some client has some flags set incorrectly we are probably ok panicking there as well as there's clearly some unexpected memory corruption or whatnot going on? |
| Comments |
| Comment by Gerrit Updater [ 05/Feb/19 ] |
|
Oleg Drokin (green@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34187 |
| Comment by Gerrit Updater [ 05/Feb/19 ] |
|
Oleg Drokin (green@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34188 |
| Comment by Gerrit Updater [ 06/Feb/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34187/ |
| Comment by Andreas Dilger [ 06/Feb/19 ] |
|
Assign to Patrick for minor cleanups discussed in patch. |
| Comment by Gerrit Updater [ 20/Mar/19 ] |
|
Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34472 |
| Comment by Gerrit Updater [ 08/Apr/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34472/ |
| Comment by Peter Jones [ 30/Apr/19 ] |
|
The bug is fixed. pfarrell can you please create a new ticket to track the cleanups. |