[LU-11945] lnetctl net add --net gni fails silently

• Status: Open
• Project: Lustre
• Affects Version/s: Lustre 2.12.0
• Type: Bug
• Priority: Minor
• Reporter: Chris Horn
• Assignee: WC Triage
• Resolution: Unresolved
• Severity: 3

Description

This fails silently:

nid00127:~ # lnetctl net add --net gni6
nid00127:~ # echo $?
0

But other network types throw an error:

nid00127:~ # lnetctl net add --net o2ib50
add:
    - net:
          errno: -2
          descr: "missing mandatory parameters in NI config: 'interface'"
nid00127:~ # lnetctl net add --net tcp50
add:
    - net:
          errno: -2
          descr: "missing mandatory parameters in NI config: 'interface'"
nid00127:~ #

Comments

[Amir Shehata (Inactive)]

Are you sure the net is not being added? I think there was an assumption that gni doesn't require an interface name:

1903 »·······/*
1904 »······· * special case the GNI since no interface name is expected
1905 »······· */
1906 »·······if (list_empty(&nw_descr->nw_intflist) &&
1907 »·······    (LNET_NETTYP(nw_descr->nw_id) != GNILND)) {
1908 »·······»·······snprintf(err_str,
1909 »·······»·······»·······sizeof(err_str),
1910 »·······»·······»·······"\"no interface name provided\"");
1911 »·······»·······rc = LUSTRE_CFG_RC_BAD_PARAM;
1912 »·······»·······goto out;
1913 »·······}