[LU-11953] Add cleanup to conf-sanity Created: 11/Feb/19 Updated: 12/Feb/19 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Patrick Farrell (Inactive) | Assignee: | WC Triage |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Looking at: https://testing.whamcloud.com/test_sets/a9c1ab0e-2d95-11e9-b3df-52540065bddc
We see that when test_93 fails, test_98 also fails because the system is not in the expected state. Most tests in conf-sanity assume the state is "cleaned up" when they start, but most of them also don't cleanup correctly on errors.
Adding cleanup to CLEANUP so it's run after every test, guaranteed, can fix most of this. |
| Comments |
| Comment by Gerrit Updater [ 11/Feb/19 ] |
|
Patrick Farrell (pfarrell@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34224 |
| Comment by Andreas Dilger [ 12/Feb/19 ] |
|
I've been wondering if conf-sanity needs a bit of an overhaul, to separate between subtests that expect the filesystem to be mounted at the start and subtests that expect to format the filesystem in a particular configuration. In the latter case it seems like we are doing a lot of extra effort to reformat the filesystem at the end of the subtest. It would be useful to see whether it would be a net improvement to just leave the filesystem unmounted at the end of the conf-sanity subtests and they are responsible for doing their own configuration. |