[#LU-1198] Change DLM lock encoding to put FID version into lock res[1]

[LU-1198] Change DLM lock encoding to put FID version into lock res[1] Created: 07/Mar/12 Updated: 07/Jun/12 Resolved: 05/Apr/12
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	Lustre 2.2.0, Lustre 2.1.2, Lustre 1.8.7
Fix Version/s:	Lustre 2.3.0, Lustre 2.1.2, Lustre 1.8.8

Type:

Task

Priority:

Minor

Reporter:

Andreas Dilger

Assignee:

Andreas Dilger

Resolution:

Fixed

Votes:

Labels:

None

Story Points:

Rank (Obsolete):

4693

Description

The FID version is currently being stored in LDLM res[2]:

struct ldlm_res_id *fid_build_reg_res_name(const struct lu_fid *f,
                                           struct ldlm_res_id *name)
{
        memset(name, 0, sizeof *name);
        name->name[LUSTRE_RES_ID_SEQ_OFF] = fid_seq(f);
        name->name[LUSTRE_RES_ID_OID_OFF] = fid_oid(f);
        name->name[LUSTRE_RES_ID_VER_OFF] = fid_ver(f);
        return name;
}

However, both the OID and VER are 32-bit values, and there is a need for quota to have 2x64 bit DLM fields for addressing per-directory quota. It is possible to move the FID VER field into the high bits of res[1] without any conflict, because the FID VER is always zero today, and there are no plans to use it in the near future. Any changes that utilize the FID VER would need client-side changes, so there is no danger that clients using the old encoding will be able to interoperate with servers using the new encoding.

Comments

Comment by Johann Lombardi (Inactive) [ 08/Mar/12 ]

For the record, this is related to ORI-558 on orion.

Comment by Andreas Dilger [ 08/Mar/12 ]

http://review.whamcloud.com/2271

Comment by Andreas Dilger [ 09/Mar/12 ]

http://review.whamcloud.com/2275

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,server,el5,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ldlm/ldlm_resource.c
lustre/utils/wiretest.c
lustre/include/lustre_fid.h
lustre/ptlrpc/wiretest.c
lustre/utils/wirecheck.c
lustre/include/lustre/lustre_idl.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ldlm/ldlm_resource.c
lustre/ptlrpc/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/utils/wirecheck.c
lustre/utils/wiretest.c
lustre/include/lustre_fid.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,client,el5,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/utils/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/include/lustre_fid.h
lustre/utils/wirecheck.c
lustre/ldlm/ldlm_resource.c
lustre/ptlrpc/wiretest.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,client,el5,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c
lustre/utils/wirecheck.c
lustre/include/lustre/lustre_idl.h
lustre/ldlm/ldlm_resource.c
lustre/include/lustre_fid.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/utils/wiretest.c
lustre/ptlrpc/wiretest.c
lustre/include/lustre_fid.h
lustre/ldlm/ldlm_resource.c
lustre/utils/wirecheck.c
lustre/include/lustre/lustre_idl.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,client,el5,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/include/lustre_fid.h
lustre/utils/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/utils/wirecheck.c
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_resource.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ldlm/ldlm_resource.c
lustre/utils/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/utils/wirecheck.c
lustre/ptlrpc/wiretest.c
lustre/include/lustre_fid.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/include/lustre_fid.h
lustre/ldlm/ldlm_resource.c
lustre/ptlrpc/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/utils/wiretest.c
lustre/utils/wirecheck.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,server,el6,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ldlm/ldlm_resource.c
lustre/include/lustre/lustre_idl.h
lustre/include/lustre_fid.h
lustre/utils/wirecheck.c
lustre/utils/wiretest.c
lustre/ptlrpc/wiretest.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,server,el5,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/utils/wirecheck.c
lustre/include/lustre_fid.h
lustre/ldlm/ldlm_resource.c
lustre/utils/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/ptlrpc/wiretest.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,client,el6,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/utils/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_resource.c
lustre/utils/wirecheck.c
lustre/include/lustre_fid.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,server,el6,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/include/lustre/lustre_idl.h
lustre/utils/wiretest.c
lustre/include/lustre_fid.h
lustre/utils/wirecheck.c
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_resource.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,client,el6,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c
lustre/utils/wirecheck.c
lustre/include/lustre_fid.h
lustre/ldlm/ldlm_resource.c
lustre/include/lustre/lustre_idl.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,server,el5,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ldlm/ldlm_resource.c
lustre/utils/wiretest.c
lustre/utils/wirecheck.c
lustre/ptlrpc/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/include/lustre_fid.h

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/include/lustre/lustre_idl.h
lustre/include/lustre_fid.h
lustre/utils/wiretest.c
lustre/ldlm/ldlm_resource.c
lustre/ptlrpc/wiretest.c
lustre/utils/wirecheck.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/utils/wirecheck.c
lustre/ldlm/ldlm_resource.c
lustre/include/lustre_fid.h
lustre/include/lustre/lustre_idl.h
lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,client,el6,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/include/lustre/lustre_idl.h
lustre/utils/wiretest.c
lustre/include/lustre_fid.h
lustre/utils/wirecheck.c
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_resource.c

Comment by Build Master (Inactive) [ 12/Mar/12 ]

Integrated in lustre-master » i686,server,el6,ofa #513
~~LU-1198~~ idl: move FID VER to DLM resource name[1] (Revision 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7)

Result = SUCCESS
Oleg Drokin : 4f91d5161d005eed6ff7a9fe6abea99690f4bcb7
Files :

lustre/ldlm/ldlm_resource.c
lustre/include/lustre/lustre_idl.h
lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c
lustre/utils/wirecheck.c
lustre/include/lustre_fid.h