[LU-12094] NULL pointer dereference in lprocfs_import_seq_write Created: 21/Mar/19  Updated: 24/Sep/21  Resolved: 07/Sep/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.13.0

Type: Bug Priority: Minor
Reporter: Alex Zhuravlev Assignee: Alex Zhuravlev
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

BUG: unable to handle kernel NULL pointer dereference at 00000000000003c4
RIP: 0010:[<ffffffffa007b2cf>] [<ffffffffa007b2cf>] lprocfs_import_seq_write+0x11f/0x520 [ptlrpc]
Call Trace:
[<ffffffffa03830e7>] mdc_import_seq_write+0x17/0x20 [mdc]
[<ffffffff81229bcd>] proc_reg_write+0x3d/0x70
[<ffffffff811b5a78>] vfs_write+0xb8/0x1d0
[<ffffffff811b6899>] SyS_write+0x69/0x110
[<ffffffff815fc6d8>] tracesys+0x8a/0xb0

looks like a race as imp was NULL:
(gdb) p &((struct obd_import *)0)->imp_connect_data.ocd_instance
$2 = (__u32 *) 0x3c4 <_ldlm_lock_debug+228>



 Comments   
Comment by Gerrit Updater [ 21/Mar/19 ]

Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34479
Subject: LU-12094 ptlrpc: lprocfs_import_seq_write() should check imp
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: dde43d07cff5a2ed63d6c69aadd18b262c85b7d5

Comment by Gerrit Updater [ 21/Aug/19 ]

James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/35853
Subject: LU-12094 obd: check if obd_import is protected in sysfs files
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2bb5dac3c84d8532a3afe888b30032077b0fe574

Comment by Gerrit Updater [ 07/Sep/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35853/
Subject: LU-12094 ptlrpc: protect obd_import in lprocfs_import_seq_write
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6d68eb9f73a0582ad5c215d210275ca20436f1d0

Comment by Peter Jones [ 07/Sep/19 ]

ok, given Alex's patch was abandoned, looks like this is resolved

Generated at Sat Feb 10 02:49:37 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.