[LU-1214] PTLRPC related modules cleanup Created: 14/Mar/12  Updated: 10/Feb/15  Resolved: 22/May/13

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.4.0, Lustre 2.7.0

Type: Task Priority: Minor
Reporter: Xuezhao Liu Assignee: Keith Mannthey (Inactive)
Resolution: Fixed Votes: 0
Labels: llite, patch
Environment:

Linux client.

Attachments: File ptlrpc_cleanup.pdf    
Issue Links:
Related
is related to LU-6206 conf-sanity test_53a: Insane OST thre... Resolved
is related to LU-6206 conf-sanity test_53a: Insane OST thre... Resolved
Rank (Obsolete): 4612

 Description   

Clean up Lustre client to facilitate pushing it into upstream Linux kernel. Need to split some server code dependencies from client to avoidmaking extensive server code changes.

There is a discussion thread at lustre-dev mail-list:
http://lists.lustre.org/pipermail/lustre-devel/2012-February/003990.html



 Comments   
Comment by Xuezhao Liu [ 21/Mar/12 ]

Four patches submitted to lustre-release/master branch:

LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery http://review.whamcloud.com/#change,2360

LU-1214 ldlm: splits server specific lock handling from client http://review.whamcloud.com/#change,2361

LU-1214 ptlrpc: removes client lu_target.h/target.c dependency http://review.whamcloud.com/#change,2362

LU-1214 quota: don't compile quota module for client http://review.whamcloud.com/#change,2363

Comment by Xuezhao Liu [ 21/Mar/12 ]

Another one patch submitted to lustre-dev/orion branch, this patch removes llog_recov_init/fini calls and recov_thread.c from client. Has some code dependency to orion branch's llog code change.

LU-1214 ptlrpc: removes recov_thread.c dependency from client http://review.whamcloud.com/#change,2364

Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/include/lustre_net.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/sec.c
  • lustre/ptlrpc/client.c
  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/events.c
  • lustre/obdecho/autoMakefile.am
  • lustre/obdecho/Makefile.in
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/niobuf.c
  • lustre/include/lustre_lib.h
  • lustre/obdecho/echo.c
  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/ptlrpc/ptlrpc_module.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,client,el5,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/niobuf.c
  • lustre/obdecho/Makefile.in
  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/client.c
  • lustre/obdecho/autoMakefile.am
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/obdecho/echo.c
  • lustre/ptlrpc/sec.c
  • lustre/ptlrpc/events.c
  • lustre/include/lustre_net.h
  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/obdecho/echo_client.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ldlm/ldlm_lib.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/obdecho/autoMakefile.am
  • lustre/obdecho/echo_client.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ptlrpc/events.c
  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/sec.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/ptlrpc/niobuf.c
  • lustre/obdecho/echo.c
  • lustre/obdecho/echo_internal.h
  • lustre/include/lustre_net.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/obdecho/Makefile.in
  • lustre/ptlrpc/client.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,client,el6,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/events.c
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/niobuf.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/obdecho/echo_internal.h
  • lustre/obdecho/Makefile.in
  • lustre/ptlrpc/sec.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/obdecho/echo.c
  • lustre/obdecho/autoMakefile.am
  • lustre/ptlrpc/client.c
  • lustre/include/lustre_lib.h
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,server,el5,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/events.c
  • lustre/obdecho/Makefile.in
  • lustre/include/lustre_sec.h
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/niobuf.c
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/client.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/obdecho/echo_internal.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/include/lustre_lib.h
  • lustre/obdecho/autoMakefile.am
  • lustre/obdecho/echo.c
  • lustre/ptlrpc/sec.c
  • lustre/ldlm/ldlm_lib.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,server,el5,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/obdecho/echo.c
  • lustre/include/lustre_net.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/include/lustre_sec.h
  • lustre/obdecho/autoMakefile.am
  • lustre/ptlrpc/client.c
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/ptlrpc/events.c
  • lustre/obdecho/echo_internal.h
  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/sec.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/niobuf.c
  • lustre/obdecho/Makefile.in
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,server,el6,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/ptlrpc/events.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/obdecho/echo.c
  • lustre/ptlrpc/niobuf.c
  • lustre/obdecho/Makefile.in
  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/client.c
  • lustre/include/lustre_net.h
  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/sec.c
  • lustre/obdecho/echo_client.c
  • lustre/obdecho/autoMakefile.am
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/include/lustre_sec.h
  • lustre/obdecho/Makefile.in
  • lustre/ptlrpc/client.c
  • lustre/ptlrpc/sec.c
  • lustre/obdecho/autoMakefile.am
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/include/lustre_lib.h
  • lustre/include/lustre_net.h
  • lustre/obdecho/echo_client.c
  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/niobuf.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/obdecho/echo.c
  • lustre/ptlrpc/events.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,server,el5,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/sec.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/niobuf.c
  • lustre/obdecho/echo.c
  • lustre/obdecho/Makefile.in
  • lustre/obdecho/echo_client.c
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/events.c
  • lustre/obdecho/autoMakefile.am
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/ptlrpc/client.c
  • lustre/include/lustre_lib.h
  • lustre/ldlm/ldlm_lockd.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,client,el6,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/ptlrpc/events.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/obdecho/echo_internal.h
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/sec.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/include/lustre_sec.h
  • lustre/obdecho/autoMakefile.am
  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/ptlrpc/client.c
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/niobuf.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/obdecho/Makefile.in
  • lustre/obdecho/echo.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,client,el5,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/ptlrpc/events.c
  • lustre/include/lustre_net.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ptlrpc/client.c
  • lustre/include/lustre_lib.h
  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/obdecho/echo.c
  • lustre/obdecho/echo_client.c
  • lustre/obdecho/echo_internal.h
  • lustre/obdecho/Makefile.in
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/sec.c
  • lustre/ptlrpc/niobuf.c
  • lustre/obdecho/autoMakefile.am
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,client,el5,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/ptlrpc/client.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ptlrpc/niobuf.c
  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/events.c
  • lustre/include/lustre_net.h
  • lustre/include/lustre_sec.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/sec.c
  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/obdecho/autoMakefile.am
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/obdecho/Makefile.in
  • lustre/obdecho/echo.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/obdecho/echo_client.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/obdecho/autoMakefile.am
  • lustre/include/lustre_lib.h
  • lustre/include/lustre_sec.h
  • lustre/obdecho/Makefile.in
  • lustre/ptlrpc/events.c
  • lustre/ptlrpc/client.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/include/lustre_net.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/sec.c
  • lustre/obdecho/echo.c
  • lustre/obdecho/echo_internal.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/niobuf.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,server,el6,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/niobuf.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ptlrpc/events.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/include/lustre_sec.h
  • lustre/ptlrpc/sec.c
  • lustre/obdecho/Makefile.in
  • lustre/obdecho/echo.c
  • lustre/ptlrpc/client.c
  • lustre/obdecho/autoMakefile.am
  • lustre/include/lustre_net.h
  • lustre/obdecho/echo_client.c
  • lustre/obdecho/echo_internal.h
  • lustre/ldlm/ldlm_lib.c
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,client,el6,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/include/lustre_lib.h
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/obdecho/echo.c
  • lustre/ptlrpc/niobuf.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/sec.c
  • lustre/obdecho/autoMakefile.am
  • lustre/include/lustre_net.h
  • lustre/obdecho/Makefile.in
  • lustre/ptlrpc/client.c
  • lustre/ldlm/ldlm_lockd.c
  • lustre/ptlrpc/events.c
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/ptlrpc_internal.h
  • lustre/include/lustre_sec.h
  • lustre/obdecho/echo_internal.h
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/ptlrpc/sec.c
  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/niobuf.c
  • lustre/ptlrpc/events.c
  • lustre/ldlm/ldlm_lib.c
  • lustre/include/lustre_net.h
  • lustre/obdecho/echo_client.c
  • lustre/include/lustre_sec.h
  • lustre/obdecho/autoMakefile.am
  • lustre/obdecho/Makefile.in
  • lustre/ptlrpc/client.c
  • lustre/include/lustre_lib.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/obdecho/echo.c
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/ptlrpc/ptlrpc_internal.h
Comment by Build Master (Inactive) [ 29/Apr/12 ]

Integrated in lustre-master » i686,server,el6,ofa #497
LU-1214 ptlrpc: splits server-side connection/bulkIO/recovery (Revision 18d78c77953017e5a76cd10bc74a0d078217a626)

Result = SUCCESS
Oleg Drokin : 18d78c77953017e5a76cd10bc74a0d078217a626
Files :

  • lustre/include/lustre_lib.h
  • lustre/include/lustre_net.h
  • lustre/ldlm/ldlm_lib.c
  • lustre/ptlrpc/sec.c
  • lustre/obdecho/echo_client.c
  • lustre/ptlrpc/events.c
  • lustre/ptlrpc/niobuf.c
  • lustre/ptlrpc/client.c
  • lustre/include/lustre_sec.h
  • lustre/ldlm/ldlm_lockd.c
  • lustre/obdecho/autoMakefile.am
  • lustre/ptlrpc/ptlrpc_module.c
  • lustre/obdecho/echo.c
  • lustre/obdecho/Makefile.in
  • lustre/obdecho/echo_internal.h
  • lustre/ptlrpc/ptlrpc_internal.h
Comment by Keith Mannthey (Inactive) [ 13/Sep/12 ]

Is this change still needed for the Orion or Master branch? What needs to happen with this code?

http://review.whamcloud.com/#change,2364

Comment by Xuezhao Liu [ 13/Sep/12 ]

That small patch (2364) was submitted to Orion due to some code dependency of llog. Seems some llog code changes are landing on Master branch, I will rebase it to Master at appropiate time when that code dependency resolved. Thanks.

Comment by Keith Mannthey (Inactive) [ 04/Jan/13 ]

Any update? I saw on Nov 7 2364 was abandoned.

Is there a separate LU to track the master change? Or can you link the master change here?

Comment by Xuezhao Liu [ 04/Jan/13 ]

There is one small patch in review:
http://review.whamcloud.com/#change,4489

Comment by Keith Mannthey (Inactive) [ 22/May/13 ]

http://review.whamcloud.com/#change,4489
Was abandoned in favor of: http://review.whamcloud.com/#change,5190 that has been merged.

I feel this LU is complete. Please reopen if I am mistaken or have missed a patch.

Comment by Keith Mannthey (Inactive) [ 22/May/13 ]

Patches were landed.

Comment by Gerrit Updater [ 03/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/2876/
Subject: LU-1214 ptlrpc: start minimum service threads
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 43f96aa9cc3cec66d9b9e0a03e5fc23e094525e7

Comment by Gerrit Updater [ 04/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/13647
Subject: Revert "LU-1214 ptlrpc: start minimum service threads"
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 280975f11e1e3e265dba05e3f1e89870739ec98f

Comment by Gerrit Updater [ 04/Feb/15 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13647/
Subject: Revert "LU-1214 ptlrpc: start minimum service threads"
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 65612d9a63139fd2a349a7eb59b32c89892249e4

Generated at Sat Feb 10 01:14:36 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.