[LU-12191] lctl list_param -R does not display everything Created: 16/Apr/19  Updated: 25/Feb/20  Resolved: 25/Feb/20

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.14.0

Type: Bug Priority: Minor
Reporter: Sonia Sharma (Inactive) Assignee: James A Simmons
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

While testing lnet sysfs patches, it is found that  lctl list_param -R does not display everything under sysfs tree.

The lnet-sysfs hierarchy is something like - 
/sys/fs/lnet/net/o2ib1/ib0

But lctl list_param -R does not display anything beyond
/sys/fs/lnet/net

This is because of the below code in param_display function in  - 

tmp = strstr(paths.gl_pathv[i], param_name);

Here instead of param_name, it should be /param_name/

 Comments   
Comment by Gerrit Updater [ 16/Apr/19 ]

Sonia Sharma (sharmaso@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34693
Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
Project: fs/lustre-release
Branch: lnet-sysfs
Current Patch Set: 1
Commit: b4527efe43d15440b8fe04a46084789f5e2244c2

Comment by Gerrit Updater [ 24/Apr/19 ]

Sonia Sharma (sharmaso@whamcloud.com) merged in patch https://review.whamcloud.com/34693/
Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
Project: fs/lustre-release
Branch: lnet-sysfs
Current Patch Set:
Commit: 797eff1f3f7accbbc6a3e40602eddd0122302587

Comment by Gerrit Updater [ 26/Nov/19 ]

James Simmons (jsimmons@infradead.org) uploaded a new patch: https://review.whamcloud.com/36852
Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a7db1acd2af8dfaea9032c55f10f67ec62095954

Comment by Gerrit Updater [ 25/Feb/20 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36852/
Subject: LU-12191 utils: Make "lctl list_param" read exact path under sysfs tree
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 45d71469226485c7bb348ffcb1700667c1fb2fa2

Comment by Peter Jones [ 25/Feb/20 ]

Landed for 2.14

Generated at Sat Feb 10 02:50:26 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.