[LU-12266] Fix up non-directory creation in SGID directories Created: 06/May/19  Updated: 09/Sep/20  Resolved: 08/May/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.7, Lustre 2.12.1
Fix Version/s: Lustre 2.13.0, Lustre 2.12.2, Lustre 2.10.8

Type: Bug Priority: Blocker
Reporter: Sebastien Buisson Assignee: Sebastien Buisson
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

If a non-directory item is created in a SGID directory, it is possible that the SGID flag is not properly cleared, leaving the item with incorrect group ownership and flags.

This is mitigated by mounting Lustre with the -o nosuid mount option on the client.

The upstream kernel has a similar issue that was fixed in commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0fa3ecd87848c9c93c2c828ef4c3a8ca36ce46c7



 Comments   
Comment by Gerrit Updater [ 06/May/19 ]

Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/34809
Subject: LU-12266 mdd: clear SGID bit on non-dirs for non-members
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b018425ae88a7348ef4c265ff5d8ed4129d136d7

Comment by Gerrit Updater [ 08/May/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34809/
Subject: LU-12266 mdd: fix up non-dir creation in SGID dirs
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 534f10e45ab1f575a0a0c81964d4792ec33696fa

Comment by Gerrit Updater [ 08/May/19 ]

Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34829
Subject: LU-12266 mdd: fix up non-dir creation in SGID dirs
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 7ba4e4cbc66ccb454395bf105523c7f57af4e556

Comment by Gerrit Updater [ 08/May/19 ]

Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/34830
Subject: LU-12266 mdd: fix up non-dir creation in SGID dirs
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 4f15cdfdbcc041b0b6fd73cfc630d84c2f488400

Comment by Peter Jones [ 08/May/19 ]

Landed for 2.13

Comment by Gerrit Updater [ 10/May/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34829/
Subject: LU-12266 mdd: fix up non-dir creation in SGID dirs
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 51a24b995e91b3d72c4ab02257e701824bae8506

Comment by Gerrit Updater [ 11/May/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/34830/
Subject: LU-12266 mdd: fix up non-dir creation in SGID dirs
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 2726fb6338be8bb5d1b5867c3bbbc574333e9186

Generated at Sat Feb 10 02:51:04 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.