[LU-12269] Support RHEL 8.0

• Status: Resolved
• Project: Lustre
• Type: Bug
• Priority: Minor
• Reporter: Jian Yu
• Assignee: Jian Yu
• Resolution: Fixed
• Labels: llnl
• Severity: 3

Description

Red Hat Enterprise Linux 8.0 is general available today:
https://access.redhat.com/announcements/4110231
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.0_release_notes/index

Issue Links

• is related to: LU-10073 lnet-selftest test_smoke: lst Error f...
• is related to: LU-12395 Failed dependencies while installing ...
• is related to: LU-11893 doesn't handle logical network interf...
• is related to: LU-12396 lfs df output is treated as binary da...
• is related to: LU-11838 Support linux kernel version 4.18
• is related to: LU-12509 lockdep warning in ofd_precreate_obje...
• is related to: LU-11233 gcc8 support
• is related to: LU-11594 sanity test_103a: FAIL: permissions f...
• is related to: LU-12398 sanity test_255b: FAIL: Ladvise willr...
• is related to: LU-12399 sanity test_420: FAIL: incorrect perm...
• is related to: LU-12456 kernel update [RHEL8.0 4.18.0-80.4.2....
• is related to: LU-12657 sanity/103 and sanityn/25 fail with 4...
• is related to: LU-12403 add e2fsprog support for RHEL-8
• is related to: LU-12270 Support linux kernel version 4.19
• is related to: LU-12331 hardened usercopy whitelisting

Comments

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34862
Subject: LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8]
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e689c78562362838bb034871616ab3a96c81ac0b

[Gerrit Updater]

Ben Menadue ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34883
Subject: LU-12269 build: remove %

{fullrelease}

from Provides
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b878ef5ddff7012ee86c2ba0268a3e0ed7e39241

[Gerrit Updater]

Ben Menadue ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34892
Subject: LU-12269 build: add value to definition of with_gss in spec
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ddb3fa2a5169fa01c9c45b012915890ca870aaa5

[Jian Yu]

After applying the following patches to the latest master branch, manual build passed:

• https://review.whamcloud.com/34882 (LU-12269 build: fix hardened builds in rpm spec file)
• https://review.whamcloud.com/34883 (LU-12269 build: remove %{fullrelease} from Provides)
• https://review.whamcloud.com/34892 (LU-12269 build: add value to definition of with_gss in spec)
• https://review.whamcloud.com/34827 (LU-12270 o2iblnd: pci_unmap_addr() removed in 4.19)
• https://review.whamcloud.com/34392 (LU-11893 ksocklnd: add secondary IP address handling)
• https://review.whamcloud.com/34234 (LU-11838: lnet: remove lnet_ipif_enumerate())
• https://review.whamcloud.com/34673 (LU-11838 llite: address_space ->page_tree renamed ->i_pages)
• https://review.whamcloud.com/34862 (LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8])

[Jian Yu]

I incorporated the above patches into a for-test-only patch in https://review.whamcloud.com/34908 to verify. Jenkins build failed as follows:

00:35:12 liblnetconfig.c: In function 'yaml_copy_peer_nids':
00:35:12 liblnetconfig.c:4321:3: error: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]
00:35:12    strncpy(nids[num], entry->cy_valuestring,
00:35:12    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
00:35:12     strlen(entry->cy_valuestring));
00:35:12     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
00:35:12 liblnetconfig.c: In function 'lnet_expr2ips':
00:35:12 liblnetconfig.c:722:30: error: '%s' directive output may be truncated writing up to 127 bytes into a region of size 104 [-Werror=format-truncation=]
00:35:12     "\"cannot parse ip_range '%s'\"", ip_range);
00:35:12                               ^~      ~~~~~~~~
00:35:12 liblnetconfig.c:720:3: note: 'snprintf' output between 27 and 154 bytes into a destination of size 128
00:35:12    snprintf(err_str,
00:35:12    ^~~~~~~~~~~~~~~~~
00:35:12     LNET_MAX_STR_LEN,
00:35:12     ~~~~~~~~~~~~~~~~~
00:35:12     "\"cannot parse ip_range '%s'\"", ip_range);
00:35:12     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
00:35:12 cc1: all warnings being treated as errors

However, the output of configure was:

00:21:24 checking for -Wno-format-truncation support... yes
00:21:24 checking for -Wno-stringop-truncation support... yes
00:21:24 checking for -Wno-stringop-overflow support... yes
<~snip~>
00:21:28 EXTRA_KCFLAGS: -include /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/undef.h -include /var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/config.h  -g -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/libcfs/include -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/lnet/include -I/var/lib/jenkins/workspace/lustre-reviews/arch/x86_64/build_type/client/distro/el8/ib_stack/inkernel/BUILD/lustre/lustre/include -Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow

The "-Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow" were specified. Not sure why they did not work.

In manual build, I specified them in CFLAGS and they worked.

[Yang Sheng]

Hi, Yujian,

EXTRA_KCFLAGS should only impact kernel build process. Are you sure it also is effect in user environment?

Thanks,
YangSheng

[Jian Yu]

I see, Yang Sheng, so that might be the reason. However, I saw those flags were also specified in EXTRA_CFLAGS in lustre-relase/Rules:

EXTRA_CFLAGS := $(EXTRA_PRE_CFLAGS)
EXTRA_CFLAGS += -include /root/lustre-release/undef.h -include /root/lustre-release/config.h  -g -I/root/lustre-release/libcfs/include -I/root/lustre-release/lnet/include -I/root/lustre-release/lustre/include -Wno-format-truncation -Wno-stringop-truncation -Wno-stringop-overflow -g -O2 -Wall -Werror
EXTRA_CFLAGS += $(EXTRA_POST_CFLAGS)

[Yang Sheng]

Hi, Yujian,

Yes, Since it was substituted from EXTRA_KCFLAGS and please note that part only apply to kernel build(when PATCHLEVEL no NULL).

Thanks,
YangSheng

[James A Simmons]

You need the LU-11233 patches.

https://review.whamcloud.com/#/c/34661/

https://review.whamcloud.com/#/c/34662/

[Jian Yu]

Thank you, Yang Sheng and James.

[Jian Yu]

After applying the following patches to the latest master branch, RHEL 8.0 Lustre client build passed: https://build.whamcloud.com/job/lustre-reviews/64783/

• https://review.whamcloud.com/34882 (LU-12269 build: fix hardened builds in rpm spec file)
• https://review.whamcloud.com/34883 (LU-12269 build: remove %{fullrelease} from Provides)
• https://review.whamcloud.com/34892 (LU-12269 build: add value to definition of with_gss in spec)
• https://review.whamcloud.com/34827 (LU-12270 o2iblnd: pci_unmap_addr() removed in 4.19)
• https://review.whamcloud.com/34392 (LU-11893 ksocklnd: add secondary IP address handling)
• https://review.whamcloud.com/34234 (LU-11838: lnet: remove lnet_ipif_enumerate())
• https://review.whamcloud.com/34673 (LU-11838 llite: address_space ->page_tree renamed ->i_pages)
• https://review.whamcloud.com/34661 (LU-11233 tests: fix gcc8 build warnings)
• https://review.whamcloud.com/34662 (LU-11233 utils: fix build warnings for gcc8)
• https://review.whamcloud.com/34862 (LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8])

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34882/
Subject: LU-12269 build: fix hardened builds in rpm spec file
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5270583ae6e436e9e7ae0199312e7f50365744af

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34883/
Subject: LU-12269 build: remove %

{fullrelease}

from Provides
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 48e16113731a1a9fff06370a0a11ea083ad290b8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34892/
Subject: LU-12269 build: add value to definition of with_gss in spec
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5bdf89f0c13eab1513d11b2e1950fba31479535d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34862/
Subject: LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8]
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d37b0ab99eaeeac391088848c275d2757b6ff17d

[James A Simmons]

3 build patches left for server support.

https://review.whamcloud.com/#/c/34675/

https://review.whamcloud.com/#/c/34689/

https://review.whamcloud.com/#/c/34674/

[Peter Jones]

Isn't https://review.whamcloud.com/#/c/33967/ needed too?

[James A Simmons]

That was mislabled. It should be apart of LU-11893 work.

[Peter Jones]

Surely it's https://review.whamcloud.com/#/c/34674/ that's mislabeled? All the patches mentioned are being tracked under LU-11893 whereas it seems like 34674 should be tracked under this ticket. No need to update now - we can fix upon landing

[Jian Yu]

Lustre build: https://build.whamcloud.com/job/lustre-master/3904/ (tag 2.12.54)
Lustre client distro: RHEL 8.0
Lustre server distro: RHEL 7.6

runtests passed: https://testing.whamcloud.com/test_sessions/d94cc3b8-8826-11e9-8c65-52540065bddc
sanity failed: https://testing.whamcloud.com/test_sessions/f122b44e-8889-11e9-be83-52540065bddc
sanity test 103a: LU-11594; test 130[b,c,e]: DCO-8347; test 255b: LU-12398; test 420: LU-12399

Another two issues are: LU-12395 and LU-12396

[James A Simmons]

The reason for the test 130[b,c,e] failure is that your missing e2fsprog for testing. Same as closed ticket https://jira.whamcloud.com/browse/LU-11666

[Jian Yu]

Yes, James. e2fsprog was not built on RHEL 8.0, so I created DCO-8347.

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35161
Subject: LU-12269 build: fix hardened builds in rpm spec file
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 4d8c4ca6e46805f89dbde7660d7f766625017121

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35162
Subject: LU-12269 build: remove %

{fullrelease}

from Provides
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 17f128793daa155cf8a730b152dd55406cc21045

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35163
Subject: LU-12269 build: add value to definition of with_gss in spec
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 5b6dc3495e42b0d974540e512086d9b40892aa78

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35164
Subject: LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8]
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 4cef0af5cdc45a69ef6ec339026284877ba6410e

[Jian Yu]

With the back-ported patches for LU-11838, LU-12269 and the following ones, RHEL 8.0 client build passed on Lustre b2_12 branch: https://build.whamcloud.com/job/lustre-reviews/65664/

• https://review.whamcloud.com/35157 (LU-12270 o2iblnd: pci_unmap_addr() removed in 4.19)
• https://review.whamcloud.com/35159 (LU-11893 ksocklnd: add secondary IP address handling)
• https://review.whamcloud.com/34583 (LU-11742 test: have libtool execute the test binaries)

[Jian Yu]

Here is the tip of the patch series (19 patches) for building RHEL 8.0 client on Lustre b2_12 branch: https://review.whamcloud.com/35164. All of the patches passed building and testing. Some of them are still pending review.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35164/
Subject: LU-12269 kernel: new kernel [RHEL 8.0 4.18.0-80.el8]
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 4ce1259293141b5a5a61103d3ff2e485c26a7fb5

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35163/
Subject: LU-12269 build: add value to definition of with_gss in spec
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: f827ee4ac860342ddc0a0118fc1da3ad5992d209

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35162/
Subject: LU-12269 build: remove %

{fullrelease}

from Provides
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: a075a457fa373ebf5f002f1f48ed6c56d1ab4dd2

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35161/
Subject: LU-12269 build: fix hardened builds in rpm spec file
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 8a8ce94397a06abf096b490c2362dea509995cdb

[Gerrit Updater]

Jian Yu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35665
Subject: LU-12269 kernel: RHEL 8.0 server support
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a7879dfa456eb036c4b2fbf98fc9e1d160940b37

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35665/
Subject: LU-12269 kernel: RHEL 8.0 server support
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f176efd183ead0b3008eb502c78b00f0c127f992

[Minh Diep]

Here is the fix for zfs build issue https://review.whamcloud.com/#/c/36095/

[Andreas Dilger]

I'm going to close this issue, since we are already working on RHEL8.2, and it is more than a year since any patches landed under this ticket.