[LU-12313] Mark lustre_inode_cache as reclaimable

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.13.0
• Type: Improvement
• Priority: Minor
• Reporter: Jacek Tomaka
• Assignee: Jacek Tomaka
• Resolution: Fixed

Description

As discussed in this email thread currently lustre does not mark memory allocated from slab as reclaimable. 

This makes the kernel's MemAvailable, SReclaimable and SUnreclaim (as reported by /proc/meminfo) unreliable, because the memory gets actually freed on memory pressure or when droping caches. 

This change should affect only how memory is reported and should not affect much else. 

As pointed out by NeilBrown other filesystems also set inode cache to reclaimable: 

That said: 9p, adfs, affs, befs, bfs, btrfs, ceph, cifs, coda, efs, ext2, ext4, f2fs, fat, freevxfs, fuse, gfs2, hpfs, isofs, jffs2, jfs, minix, nfs, nilfs, ntfs, ocfs2, openpromfs, overlayfs, procfs, qnx4, qnx6, reiserfs, romfs, squashfs, sysvfs, ubifs, udf, ufs, xfs all set SLAB_RECLAIM_ACCOUNT on their inode caches.

 Also from NeilBrown: 

Yes, I think lustre_inode_cache should certainly be flagged as
SLAB_RECLAIM_ACCOUNT.
If the SReclaimable value is too small (and there aren't many
reclaimable pagecache pages), vmscan can decide not to bother. This is
probably a fairly small risk but it is possible that the missing
SLAB_RECLAIM_ACCOUNT flag can result in memory not being reclaimed when
it could be.

 
It remains open question which other caches could also be marked as reclaimable but marking just lustre_inode_cache would be a good improvement.

Issue Links

• is related to: LU-13909 release invalid dentries proactively ...

Comments

[Gerrit Updater]

Jacek Tomaka ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35790
Subject: LU-12313 llite: Mark lustre_inode_cache as reclaimable
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7f81c23593bc009d98853b031c4451ac04defe2e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35790/
Subject: LU-12313 llite: Mark lustre_inode_cache as reclaimable
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b09e63db24e5770b0a53ac6d68f91f08dc368be4

[Peter Jones]

Landed for 2.13