[LU-12383] lfs project inhert difference between ldiskfs and zfs

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.13.0
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.3
• Type: Bug
• Priority: Critical
• Reporter: Nathaniel Clark
• Assignee: Wang Shilong (Inactive)
• Resolution: Fixed
• Labels: quota
• Severity: 3

Description

Regular files inherit the Project Inherit flag in ldiskfs, zfs they do not.

Given the following commands:

mkdir proj
lfs project -sp 1000 proj
touch proj/test
lfs project proj

ldiskfs output:

 1000 P proj/test 

ZFS 0.8.0 output:

 1000 - proj/test

 Both correctly set inherit on sub-directories.

 

This difference in behavior causes sanity-quota test_54 to fail for ZFS 0.8.0

https://testing.whamcloud.com/test_sets/afa8f438-81b8-11e9-869c-52540065bddc

Issue Links

• is blocking: LU-12336 Update ZFS Version to 0.8.2

Comments

[Nathaniel Clark]

Is there a specification for behavior of the INHERIT bit on regular files?  It seems that it doesn't make sense for the inherit bit to be set on a regular file, just on sub-directories.

There would be three ways to fix this. 

1. Alter ZFS (or osd-zfs) to set inherit bit on files created under directory with it set
2. Change sanity-quota/test_54 to not care if bit is set on those files ("c1")
3. Alter lfs project -c to not complain if inherit bit is "missing" from regular files

My initial impression is that, I'm not sure #1 is "correct".  #2 seems like a hack, so I think #3 is best option, since I don't feel like it makes sense for a regular file to have this bit set.

[Andreas Dilger]

How does the inheritance of this flag work on native ext4 and XFS? To my thinking, it doesn't make sense to inherit this flag on regular files, only directories. That would imply the correct fix is a fourth option - not to inherit the flag in ldiskfs, and match the behavior of ZFS, but let's first see how other filesystems handle it.

[Wang Shilong (Inactive)]

I just checked Upstream ext4 and xfs:

XFS only inherit inherit flag for Directory, but ext4 always inherit it for dirs/regular files.
To fix this problem, I'd prefer:

1) Alter lfs project -c to only complain if inherit bit is "missing" from Directory.
2) send a patch to upstream ext4 to keep consistent behavior with ext4 with xfs/zfs.

Notice, even we have inherit flag for regular files, it dose no harm as well.

[Gerrit Updater]

Wang Shilong ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35076
Subject: LU-12383 utils: only check project inherit bit for dir
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 745050395fdb431e24b4cc7c07f8cefa360bf6a4

[Wang Shilong (Inactive)]

Following simple ext4 patch shall fix the problem:

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 1cb67859e051..ceb74093e138 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -421,7 +421,8 @@ struct flex_groups {
                           EXT4_PROJINHERIT_FL | EXT4_CASEFOLD_FL)
 
 /* Flags that are appropriate for regular files (all but dir-specific ones). */
-#define EXT4_REG_FLMASK (~(EXT4_DIRSYNC_FL | EXT4_TOPDIR_FL | EXT4_CASEFOLD_FL))
+#define EXT4_REG_FLMASK (~(EXT4_DIRSYNC_FL | EXT4_TOPDIR_FL | EXT4_CASEFOLD_FL |\
+                          EXT4_PROJINHERIT_FL))
 
 /* Flags that are appropriate for non-directories/regular files. */
 #define EXT4_OTHER_FLMASK (EXT4_NODUMP_FL | EXT4_NOATIME_FL)

[Wang Shilong (Inactive)]

FYI, I sent two Linux upstream patches to fix ext4 and f2fs:

http://patchwork.ozlabs.org/patch/1110877/
http://patchwork.ozlabs.org/patch/1110878/

[Andreas Dilger]

Please also submit an ldiskfs patch for this, I have also reviewed the ext4 patch on the list.

[Wang Shilong (Inactive)]

Andreas,

Since there won't be obvious errors with LU-12383 utils: only check project inherit bit for dir
Do you think we'd better include ldiskfs fix parts too?

[Andreas Dilger]

I think it makes sense to include ldiskfs-side patches, so that we get fewer "corrupt" inodes on a filesystem, and hopefully they can mostly be aged out of the filesystem after the ldsiskfs patch has been around for some time.

We will also want a patch for e2fsck to detect and repair these errors on non-directory inodes without complaining too much.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35076/
Subject: LU-12383 utils: only check project inherit bit for dir
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e4ad5c17c99e7ede5deabffe0bacdd851240eb86

[Peter Jones]

Landed for 2.13

[Li Xi]

Should we create another ticket to track the ldiskfs patch?

[Peter Jones]

We can reopen this one if it seems likely to complete this work during the 2.13 cycle. If that is in doubt then, sure, let's have a new ticket linked to this one

[Gerrit Updater]

Wang Shilong ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35393
Subject: LU-12383 utils: only check project inherit bit for dir
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: b84e222d7075acc702a239ee4ece3c71e22576a0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35393/
Subject: LU-12383 utils: only check project inherit bit for dir
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 1299c5d5f92a7086b48b721d35bfce9ded177b94