[LU-12401] Various issues with checksum calculation for Kerberos and SSK Created: 07/Jun/19  Updated: 26/Jul/19  Resolved: 17/Jul/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.13.0
Fix Version/s: Lustre 2.13.0, Lustre 2.12.3

Type: Bug Priority: Minor
Reporter: Sebastien Buisson Assignee: Sebastien Buisson
Resolution: Fixed Votes: 0
Labels: gss

Issue Links:
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

When computing checksum for Kerberos, krb5 wire token header is appended to the plain text. We need to make sure the actual header is appended in gss_digest_hash().

In gss_crypt_generic(), it is better to protect against an undefined behavior by
switching from memcpy to memmove.



 Comments   
Comment by Gerrit Updater [ 07/Jun/19 ]

Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/35099
Subject: LU-12401 gss: fix checksum for Kerberos
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5d539c480e352db07adf12f5b53878a67b8e5fd2

Comment by Sebastien Buisson [ 20/Jun/19 ]

Also, when computing checksum for SSK, we need to make sure the actual token is used to store the checksum.

Comment by Gerrit Updater [ 17/Jul/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35099/
Subject: LU-12401 gss: fix checksum for Kerberos and SSK
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 218fc688c11f081881b2cc1c1632ceaf9ec77a77

Comment by Gerrit Updater [ 17/Jul/19 ]

Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/35536
Subject: LU-12401 gss: fix checksum for Kerberos and SSK
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 61d18ff20a8ba3e2377aafe60156bdf021902ba4

Comment by Peter Jones [ 17/Jul/19 ]

Landed for 2.13

Comment by Sebastien Buisson [ 19/Jul/19 ]

Still trying to have patch https://review.whamcloud.com/35536 landed for next 2.12 release.

Comment by Gerrit Updater [ 26/Jul/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35536/
Subject: LU-12401 gss: fix checksum for Kerberos and SSK
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: d29eea632bb8a99b83442ba7946707e8baf2dcef

Generated at Sat Feb 10 02:52:15 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.