[LU-12420] llog_reader crashes when reading llog that is not inited

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.13.0
• Type: Bug
• Priority: Minor
• Reporter: Li Xi
• Assignee: Li Xi
• Resolution: Fixed
• Severity: 3

Description

I think the problem is easy to reproduce. On a Lustre file system that doesn't have nodemap configured, which is the majority case I think, do the following:

1. mount -t ldiskfs $MGT $MNT
2. llog_reader $MNT/CONFIGS/nodemap
   llog_reader will quit with following error:

 llog_reader: Error allocating -16 bytes for recs_buf: Cannot allocate memory (12)
 llog_reader: Could not pack buffer.: Cannot allocate memory (12)

Apparently, the llog of nodemap is never initialized so all the values are gabage.

Header size : 3987452397
Time : Fri Jan 2 20:30:12 1970
Number of records: 4294967295
Target uuid :

I think in this case, llog_reader should just quit with proper message printed.

Issue Links

• is related to: LU-6932 llog_reader segfault on corrupted file

Comments

[Gerrit Updater]

Li Xi ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35177
Subject: LU-12420 utils: llog_reader handles uninitialized llog properly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6adef13baa9ce18da9a164b79924f298c000574c

[Gerrit Updater]

Li Xi ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35178
Subject: LU-12420 utils: llog_reader handles uninitialized mountdata
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ad12f4bbd1f37c48663a049308414a726e05c3df

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35177/
Subject: LU-12420 utils: llog_reader handles uninitialized llog properly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 94a16a027536100a9d0a279e1f384076a7a9b513

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35178/
Subject: LU-12420 utils: llog_reader handles uninitialized mountdata
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 46f53da979344c88ab985de7227a81240a8107bf

[Li Xi]

I am closing this ticket since all two patches are merged.

[Gerrit Updater]

"Etienne AUJAMES <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/48302
Subject: LU-12420 utils: llog_reader handles uninitialized llog properly
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: baae76f7f248d841c400d36a59f5c82ca6729a4c

[Gerrit Updater]

"Etienne AUJAMES <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/48303
Subject: LU-12420 utils: llog_reader handles uninitialized mountdata
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 687bffe3e462764cf25015e53de9bc1d687c130a