[LU-12477] Remove obsolete config checks

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.14.0
• Type: Improvement
• Priority: Minor
• Reporter: Patrick Farrell (Inactive)
• Assignee: James A Simmons
• Resolution: Fixed
• Labels: easy

Description

As of 2.12/2.13, we no longer support many older kernels, including anything in the 2.x vintage.

This is a ticket to track removing some of the config checks for these versions.

Issue Links

• is related to: LU-14453 LDISKFS-fs error (device xxx) in ldis...
• is related to: LU-14823 re-enable open-by-handle tests
• is related to: LU-12561 Remove RHEL6/SLES11 support from mast...
• is related to: LU-13127 make Lustre error when hash algo is n...

Comments

[Patrick Farrell (Inactive)]

I got inspired to do a few of these this morning, I have zero intention of trying to get them all.

Right now, I have:
https://review.whamcloud.com/35342
https://review.whamcloud.com/35343
https://review.whamcloud.com/35344

For this.

These cover, I believe:
All the obsolete libcfs checks

The 'easy for Patrick to understand' obsolete lnet checks (so nothing in the OFED checking)

And the last one is just scraping the surface of the core Lustre checks, of which there are a lot.

There are many, many obsolete checks not covered here.  This would be a good newbie project...

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35461
Subject: LU-12477 llite: use generic_error_remove_page()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 23eb08f241e4d177f8e892fdbe748711854f4865

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35462
Subject: LU-12477 lustre: use delete_from_page_cache() for directory pages.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 539fe85d2e2da65988873d199d5031d50ed35346

[James A Simmons]

Applied the two above patches will let use remove lustre_patchless_compat.h and it autoconf test.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35461/
Subject: LU-12477 llite: use generic_error_remove_page()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f114d4dac6f842212e248f2ed4a50ce3249109d8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35462/
Subject: LU-12477 lustre: use delete_from_page_cache() for directory pages.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 43d5806ffe6d6017aea0892de78dc27e54861de1

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35539
Subject: LU-12477 kernel: eliminate lustre_patchless_compat.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 91097dd068e61bd57c154a86b300636b9e61d863

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/35551
Subject: LU-12477 kernel: remove 2.6 kernel support
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9dc477ccf810a9da7df96ea13e51852c4cb38e2e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35551/
Subject: LU-12477 kernel: remove < 2.6.39 kernel support
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5595f7b429ded89d9925ec98696da1a1727034e7

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35539/
Subject: LU-12477 kernel: eliminate lustre_patchless_compat.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ab38b346d9176dce1b02cf631db31998e0170832

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35343/
Subject: LU-12477 lnet: Remove obsolete config options
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 25929ea0d2955afc6fb1150e57fd8e527ffc6b4f

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37085
Subject: LU-12477 lustre: remove obsolete config checks
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b3db43823a10e5a1e0e26229f6b7d77bfbb6ea6c

[Andreas Dilger]

James, what do you think about splitting the configure checks into common and server-only sections? That would probably remove a bunch of checks from the client build process, which is one of the slower parts of the build today.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35342/
Subject: LU-12477 libcfs: Remove obsolete config checks
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c4c17fa4a3f5d9c3df44e19ab3385c8de655cdef

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37352
Subject: LU-12477 ldiskfs: remove obsolete ext4 patches
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 33c0a1768c4070e604863ecf439f3151e7322084

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37085/
Subject: LU-12477 lustre: remove obsolete config checks
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8e88bbfef5795b3bf9541c8cb5b2dd8a3bb11d9f

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37725
Subject: LU-12477 lustre: restore time_after32()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d04651d36cbfedf9b3c75ffaea13f9cee3fb3bb9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37725/
Subject: LU-12477 lustre: restore time_after32()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 33141a149023ac5c3631da911cbc67116f915464

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37352/
Subject: LU-12477 ldiskfs: remove obsolete ext4 patches
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fc87b01f96e8485a3713d0e446551e985e0e4aa0

[Peter Jones]

Looks like this has all landed for 2.14

[James A Simmons]

A cleanup of the kernel patches are left. Also the old dev rdonly work can be removed.

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38068
Subject: LU-12477 kernel: remove dev_read_only handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 45bfcd1a1af8d1fcb6e5d527abc863b2ac51ae4d

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38070
Subject: LU-12477 kernel: remove dev_read_only handling
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: dea498289bf70fb1a3b59d03e5bb03816ce18ae3

[Arshad Hussain]

Hi James,

A small change in "lustre/Changelog" is also required.

# git diff
diff --git a/lustre/ChangeLog b/lustre/ChangeLog
index dfb5fa8..a20c9d4 100644
--- a/lustre/ChangeLog
+++ b/lustre/ChangeLog
@@ -5,7 +5,6 @@ TBD Whamcloud
        * Server primary kernels built and tested during release cycle:
          3.10.0-1062.9.1.el7 (RHEL7.7)
        * Other server kernels known to build and work at some point (others may also work):
-         3.10.0-862.14.4.el7 (RHEL7.5)
          3.10.0-957.27.2.el7 (RHEL7.6)
          4.18.0-80.11.2.el8  (RHEL8.0)
          4.18.0-147.3.1.el8  (RHEL8.1)

I ran into the compatibility issue first hand as I was still using 3.10.0-862.14.4.el7 (RHEL7.5) as my dev system. Of course after a bump to 3.10.0-957.27.2.el7 (7.6) things are fine now.

Thanks

 

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38139
Subject: LU-12477 ldiskfs: cleanup left over mballoc prefetch patch
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 09f74f159bc60aa71d8d0fbe963737b4925231af

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38070/
Subject: LU-12477 kernel: remove dev_read_only handling
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 20553c985a518ebc1d5da2a1ddf44c4eec3db044

[Gerrit Updater]

Shaun Tancheff ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38268
Subject: LU-12477 ldiskfs: drop support for sles12
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2bc4770ed8c79da2d6c6e4dc2c01df23c62371c5

[Gerrit Updater]

Shaun Tancheff ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38269
Subject: LU-12477 kernel: drop support for unused patches
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5b247e40989e69166c497998fe1b2f35b187d6ed

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38438
Subject: LU-12477 ldiskfs: finish removing HAVE_CLEAR_RDONLY_ON_PUT
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c5285d6c35b2fb1bfaf3be319621f7b462e4ce89

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38139/
Subject: LU-12477 ldiskfs: last cleanups
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ce4d3aaac7c25d0b00f610e0fbd8f4142df6a80f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38438/
Subject: LU-12477 ldiskfs: finish removing HAVE_CLEAR_RDONLY_ON_PUT
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 50b6be5d1d5e2d7a7954df82fbda7af93471550e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38268/
Subject: LU-12477 ldiskfs: drop SUSE kernel 4.4 and earlier
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 89075044b3a86454cc542e6a5a2994d44f667ac9

[Peter Jones]

Is this work complete or is there more to come still?

[Shaun Tancheff]

From my perspective there is nothing further.

[Peter Jones]

ok - thanks stancheff

[James A Simmons]

I concur. Our patchset is so much smaller

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40831
Subject: LU-12477 libcfs: Further reduce complexity for shrinkers.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 549435cd15bf1f1c2d038da8843ce1229074b60f

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/40883
Subject: LU-12477 lustre: check return status of register_shrinker()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b388d26f5580b7ecbd46beb107d01c0698b7503f

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/41086
Subject: LU-12477 llite: remove unused ll_teardown_mmaps()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 216e7cae0fd736971aaa95974f72b76a2b546014

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/41086/
Subject: LU-12477 llite: remove unused ll_teardown_mmaps()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 647c96562b27cef99e5986911c4db83dcfee0620

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/40831/
Subject: LU-12477 libcfs: Further reduce complexity for shrinkers.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 782725b11021b2f1c3467863216836ee94bcd874

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/40883/
Subject: LU-12477 lustre: check return status of register_shrinker()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 812b2ccf0284df42e8a88a6b7c4c3874dd721c71

[Gerrit Updater]

Sebastien Buisson ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43623
Subject: LU-12477 libcfs: Remove obsolete config checks
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 2828793cd9d4938ca95b509ad73c7342dca7043b