[LU-12535] lov_page_index surprisingly slow Created: 11/Jul/19  Updated: 24/Sep/19  Resolved: 16/Sep/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.13.0

Type: Improvement Priority: Minor
Reporter: Patrick Farrell (Inactive) Assignee: Patrick Farrell (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
Rank (Obsolete): 9223372036854775807

 Description   

When doing readahead, we see an amazing amount of time (~5%) just looking up the page index from the lov layer.

 a
-   84.42%     0.34%  ior              [kernel.kallsyms]     [k] ll_readpage                a
   - 84.08% ll_readpage                                                                     a
      - 82.68% ll_io_read_page                                                              a
         + 68.53% ll_readahead.isra.27                                                      a
         - 14.14% cl_io_submit_rw                                                           a
            - 13.40% lov_io_submit                                                          a
               - 8.24% lov_page_index                                                       a
                    5.56% cl_page_at  

This never changes once a page is created, so we can just store it at the top layer.



 Comments   
Comment by Gerrit Updater [ 11/Jul/19 ]

Patrick Farrell (pfarrell@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35470
Subject: LU-12535 lov: Move page index to top level
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 17f9a3b0a8163c0adeac0c1e681302e24d84d9f1

Comment by Patrick Farrell (Inactive) [ 11/Jul/19 ]

I thought this was due to a bug in another patch, but it seems to be, surprisingly, real.  Let's get it fixed...

Comment by Gerrit Updater [ 16/Sep/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35470/
Subject: LU-12535 lov: Move page index to top level
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8d6d2914cf85be0508805cd5195163e1959652f4

Comment by Peter Jones [ 16/Sep/19 ]

Landed for 2.13

Generated at Sat Feb 10 02:53:27 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.