[LU-12639] sanity test 317 uses uninitialized variable $facet Created: 07/Aug/19  Updated: 21/Nov/19  Resolved: 15/Aug/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.13.0, Lustre 2.12.3
Fix Version/s: Lustre 2.13.0, Lustre 2.12.4

Type: Bug Priority: Minor
Reporter: James Nunez (Inactive) Assignee: James Nunez (Inactive)
Resolution: Fixed Votes: 0
Labels: tests

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

sanity test 317 checks the file system type of $facet to determine if the test should be skipped. Unfortunately, facet is not initialized/defined in the test.

19369 test_317() {
19370         [ $MDS1_VERSION -lt $(version_code 2.11.53) ] &&
19371                 skip "Need MDS version at least 2.11.53"
19372         local trunc_sz
19373         local grant_blk_size
19374 
19375         if [ "$(facet_fstype $facet)" == "zfs" ]; then
19376                 skip "LU-10370: no implementation for ZFS" && return
19377         fi
...

We need to replace $facet with the correct server.

Test 317 was added to sanity with patch https://review.whamcloud.com/31073 .



 Comments   
Comment by Gerrit Updater [ 07/Aug/19 ]

James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/35716
Subject: LU-12639 tests: initialize variable sanity 317
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ad5d4dc98e0086fb1af08815c94167793956e165

Comment by Gerrit Updater [ 15/Aug/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35716/
Subject: LU-12639 tests: initialize variable sanity 317
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c00be06a1f8f27eb5bd8bb47086d0f1e5b5f5f50

Comment by Peter Jones [ 15/Aug/19 ]

Landed for 2.13

Comment by Gerrit Updater [ 03/Oct/19 ]

James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36366
Subject: LU-12639 tests: initialize variable sanity 317
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: ba6481af862ca414817421d8ab52b917ab3f8871

Comment by Gerrit Updater [ 21/Nov/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36366/
Subject: LU-12639 tests: initialize variable sanity 317
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 97ece1cae18902fd0f6844855723965e5ca4fcf0

Generated at Sat Feb 10 02:54:21 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.