[LU-12686] ln_mt_waitq use by lnet monitor thread is completely ineffective Created: 23/Aug/19 Updated: 16/Sep/19 Resolved: 16/Sep/19 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.13.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Neil Brown | Assignee: | Neil Brown |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
The ln_mt_waitq is only ever waited on by a wait_event_interruptble_timeout() call which waits for 'false' to be 'true'. As false is never true, this always waits the full timeout, which makes the waitq pointless, and explains the effort that has gone in to choosing a good timeout value. Place that wakeup this waitqueue should set a flag so that lnet_monitor thread knows something has happened and that it should stop waiting. This is most easily done by changing the waitqueue to a completion, as a compltion is a waitqueue combined with a flag (actually a counter).
The timeout should be changed too - probably it can then be must larger.
|
| Comments |
| Comment by Gerrit Updater [ 23/Aug/19 ] |
|
Neil Brown (neilb@suse.com) uploaded a new patch: https://review.whamcloud.com/35874 |
| Comment by Gerrit Updater [ 16/Sep/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35874/ |
| Comment by Peter Jones [ 16/Sep/19 ] |
|
Landed for 2.13 |