[LU-12691] obd_max_recoverable_clients is not atomic Created: 26/Aug/19  Updated: 29/May/20  Resolved: 09/Oct/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.8
Fix Version/s: Lustre 2.13.0, Lustre 2.12.4

Type: Bug Priority: Major
Reporter: Tatsushi Takamura Assignee: Tatsushi Takamura
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
duplicates LU-11001 insanity test_2: :check_for_recovery_... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

Originally obd_max_recoverable_clients is not increased at the same moment.
But because of LU-3540, it will be increased by multiple processes.
This causes LBUG.

The type of obd_max_recoverable_clients should be atomic_t and be handled by atomic operations.

 Comments   
Comment by Gerrit Updater [ 26/Aug/19 ]

Tatsushi Takamura (takamr.tatsushi@jp.fujitsu.com) uploaded a new patch: https://review.whamcloud.com/35914
Subject: LU-12691 ldlm: obd_max_recoverable_clients is not atomic
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8772d09ae7ed23f8d29a8f3404c42ae095c53431

Comment by Tatsushi Takamura [ 29/Aug/19 ]

We hit this LBUG when running insanity test4. (According to the crash dump, LU-11001 seems to be the same issue)

 

00010000:00040000:0.0:1520239440.432805:0:10096:0:(ldlm_lib.c:2206:check_for_recovery_ready()) ASSERTION( clnts <= obd->obd_max_recoverable_clients ) failed:
00010000:00040000:0.0:1520239440.432814:0:10096:0:(ldlm_lib.c:2206:check_for_recovery_ready()) LBUG

After applying this patch, this LBUG have not been reproduced.

 

 

Comment by Gerrit Updater [ 09/Oct/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35914/
Subject: LU-12691 ldlm: obd_max_recoverable_clients is not atomic
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 01261e7b563adc97899d962f0ba2d1b430894bf7

Comment by Peter Jones [ 09/Oct/19 ]

Landed for 2.13

Comment by Gerrit Updater [ 26/Nov/19 ]

Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36878
Subject: LU-12691 ldlm: obd_max_recoverable_clients is not atomic
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: fe66543cb7e0abdd0daaf8c4be0fccf41f299787

Comment by Gerrit Updater [ 12/Dec/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36878/
Subject: LU-12691 ldlm: obd_max_recoverable_clients is not atomic
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: ccd89f519d4cdb3ebf971edf178f9cd2e664beec

Generated at Sat Feb 10 02:54:48 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.