[LU-12694] make "lfs quota" display correct group quota information Created: 26/Aug/19  Updated: 01/Jun/20  Resolved: 07/Sep/19

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.8
Fix Version/s: Lustre 2.13.0

Type: Bug Priority: Major
Reporter: Tatsushi Takamura Assignee: Tatsushi Takamura
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-12868 sanity-quota test 65 100% failure Open
Epic/Theme: Quota
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

lfs quota (without -g option) doesn't show correct group quota information

# lfs quota /lustre/
Disk quotas for usr root (uid 0):
     Filesystem  kbytes   quota   limit   grace   files   quota   limit   grace
       /lustre/   13208       0       0       -    1096       0       0       -
Disk quotas for grp root (gid 0):
     Filesystem  kbytes   quota   limit   grace   files   quota   limit   grace
       /lustre/       0       0       0       -       0       0       0       -

* kbytes(0 is dispolayed) should be 13208

# lfs quota -g root /lustre/
Disk quotas for grp root (gid 0):
     Filesystem  kbytes   quota   limit   grace   files   quota   limit   grace
       /lustre/   13208       0       0       -    1096       0       0       -

This is because, on the server side GETQUOTA is not executed when oqctl->qc_dqblk.dqb_curspace not 0. So, qctl.qc_dqblk need to be cleared to display correct.

static int quotactl_ioctl(struct ll_sb_info *sbi, struct if_quotactl *qctl)
{
<snip>
                if (cmd == Q_GETQUOTA &&
                    !(oqctl->qc_dqblk.dqb_valid & QIF_SPACE) &&
                    !oqctl->qc_dqblk.dqb_curspace) {


 Comments   
Comment by Gerrit Updater [ 26/Aug/19 ]

Tatsushi Takamura (takamr.tatsushi@jp.fujitsu.com) uploaded a new patch: https://review.whamcloud.com/35917
Subject: LU-12694 quota: display correct group quota information
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0f5b713675aeffff8eaa5bbfb6caaf6dcebd3f94

Comment by Gerrit Updater [ 07/Sep/19 ]

Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/35917/
Subject: LU-12694 quota: display correct group quota information
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5c033757a9a36b83bf891715e683ed06a4bded8e

Comment by Peter Jones [ 07/Sep/19 ]

Landed for 2.13

Generated at Sat Feb 10 02:54:50 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.