[LU-12760] sanity test_161d incorrect use of stack_trap

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.13.0
• Fix Version/s: Lustre 2.13.0, Lustre 2.12.4
• Type: Bug
• Priority: Minor
• Reporter: Oleg Drokin
• Assignee: Andreas Dilger
• Resolution: Fixed
• Severity: 3

Description

stack_trap uses two arguments, the second being the signal to trap.

Yes test_161d has this:

        stack_trap "rm -f $tempfile"

the end result is this:

== sanity test 161d: create with concurrent .lustre/fid access ======================================= 07:42:56 (1568374976)
mdd.lustre-MDT0000.changelog_mask=+hsm
Registered 1 changelog users: 'cl13'
fail_loc=0x8000140c
fail_val=5
  PID TTY          TIME CMD
  490 pts/0    00:00:00 bash
/home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6086: trap: : invalid signal specification
/home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6093: trap: : invalid signal specification
/home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6094: trap: : invalid signal specification
/home/green/git/lustre-release/lustre/tests/test-framework.sh: line 6095: trap: : invalid signal specification
/home/green/git/lustre-release/lustre/tests/test-framework.sh: eval: line 6099: unexpected EOF while looking for matching `''
/home/green/git/lustre-release/lustre/tests/test-framework.sh: eval: line 6100: syntax error: unexpected end of file

sohuld add EXIT to the the end of stack_trap call.

Comments

[Andreas Dilger]

I'd rather that the default signalspec was EXIT, since that seems to be the only signal that we use anyway:

stack_trap()
{       
        local arg="$1"
        local sigspec="${2:-EXIT}"

That way it would only need to be specified if it was some other signal.

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36186
Subject: LU-12760 tests: stack_trap defaults to sigspec=EXIT
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 567a1ff65de6dad06c3f9bde52542c980b2fd48f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36186/
Subject: LU-12760 tests: stack_trap defaults to sigspec=EXIT
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5a911faae25784a91fc085debeb6dbe8512d80b6

[Peter Jones]

Landed for 2.13

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36938
Subject: LU-12760 tests: stack_trap defaults to sigspec=EXIT
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: a85a6c73a51c158b695697d71eaeb88ef12d633c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36938/
Subject: LU-12760 tests: stack_trap defaults to sigspec=EXIT
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: 517c08e2e83eaf14ecf03eb593246fb2e408bf69