[LU-12898] building lustre utils on ppc64le fails with error format expects llu but argument is __u64

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.12.3
• Fix Version/s: Lustre 2.14.0, Lustre 2.12.4
• Type: Bug
• Priority: Minor
• Reporter: Olaf Faaland
• Assignee: Olaf Faaland
• Resolution: Fixed
• Labels: llnl, llnlfixready
• Severity: 3

Description

Several utilities fail to build with errors like this one:

BUILDSTDERR: libmount_utils_zfs.c: In function 'zfs_mkfs_opts':
BUILDSTDERR: libmount_utils_zfs.c:573:5: error: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type '__u64' [-Werror=format=]
BUILDSTDERR:      mop->mo_device_kb * 1024);

utilities affected:

lustre/utils/ll_decode_filter_fid.c
lustre/utils/llog_reader.c
lustre/utils/lr_reader.c
lustre/utils/lsnapshot.c
lustre/utils/lustre_lfsck.c

Issue Links

• duplicates: LU-12705 build fails on power9 client

Comments

[Olaf Faaland]

I am working through them and will have a patch, after I rebase on master.

[Gerrit Updater]

Olaf Faaland-LLNL ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36558
Subject: LU-12898 utils: %llu mismatch with type __u64 on ppcle64
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 79f55c12a3f78495d56a66884b84f6f3f4c97f3a

[Peter Jones]

Thanks Olaf

[Andreas Dilger]

It looks like this is a dupe of LU-12705, which already has a patch on master. Rather than making a new patch, the patches from that ticket should be cherry-picked to b2_12

[Andreas Dilger]

Hmm, it looks like those patches are already backported to b2_12... Do the same compile problems exist on master, or only b2_12? Typically we do not accept patches for only LTS branches until they have been landed for master first, so that we don't lose fixes going forward.

[Andreas Dilger]

Doh! Your patch is for master... For some reason I thought the patch was pushed against b2_12 only. Too early I guess.

[Andreas Dilger]

I was trying to understand why we didn't see these problems with LU-12705, but it looks like these compile warnings are all in the server code, which we do not build/test on PPC.

Olaf, are you trying to actually use PPC64le nodes for servers, or is this just because you are building both client+server packages normally and only the packages will only be used on the clients? We definitely haven't done much testing with large PAGE_SIZE on the server.

[Olaf Faaland]

I was trying to understand why we didn't see these problems with LU-12705, but it looks like these compile warnings are all in the server code, which we do not build/test on PPC.

That question has been bothering me, and I didn't connect the dots. Thanks for pointing that out.

Olaf, are you trying to actually use PPC64le nodes for servers, or is this just because you are building both client+server packages normally and only the packages will only be used on the clients? We definitely haven't done much testing with large PAGE_SIZE on the server.

We just build client+server packages as a routine practice; we're not trying to use PPCE64le servers. Thanks for the warning.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36558/
Subject: LU-12898 utils: %llu mismatch with type __u64 on ppcle64
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 56b4b112a497661de8dbf5a851c7a045d470deff

[Peter Jones]

Landed for 2.14

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37130
Subject: LU-12898 utils: %llu mismatch with type __u64 on ppcle64
Project: fs/lustre-release
Branch: b2_12
Current Patch Set: 1
Commit: 1417405546b58bdc11d10a7bf052b7ba0d1eefa0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37130/
Subject: LU-12898 utils: %llu mismatch with type __u64 on ppcle64
Project: fs/lustre-release
Branch: b2_12
Current Patch Set:
Commit: ccaae9deb5b02a789ca0a645d4ca2359f300132f