[LU-12967] sanity test 80 silently fails to get sync_on_lock_cancel parameter Created: 13/Nov/19 Updated: 14/Oct/21 Resolved: 16/Dec/19 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | Lustre 2.12.0, Lustre 2.13.0, Lustre 2.14.0 |
| Fix Version/s: | Lustre 2.14.0, Lustre 2.12.4 |
| Type: | Bug | Priority: | Minor |
| Reporter: | James Nunez (Inactive) | Assignee: | James Nunez (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||
| Severity: | 3 | ||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||
| Description |
|
There are actually two issues with sanity test_80 as see here in the suite_log to https://testing.whamcloud.com/test_sets/92b52b08-05c5-11ea-9487-52540065bddc == sanity test 80: Page eviction is equally fast at high offsets too ================================ 19:09:39 (1573585779)
CMD: trevis-34vm3 lctl get_param -n obdfilter.*.sync_on_lock_cancel
trevis-34vm3: error: get_param: param_path 'obdfilter/*/sync_on_lock_cancel': No such file or directory
CMD: trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3 lctl set_param obdfilter.*.sync_on_lock_cancel=never
pdsh@trevis-34vm1: gethostbyname("trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3") failed
1+0 records in
1+0 records out
1048576 bytes (1.0 MB) copied, 0.00475709 s, 220 MB/s
CMD: trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3 lctl set_param obdfilter.*.sync_on_lock_cancel=
pdsh@trevis-34vm1: gethostbyname("trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3trevis-34vm3") failed
One issue is that it looks like the obdfilter.*.sync_on_lock_cancel parameter no longer exists and the host name composed in the test is problematic. The test does not fail when it hits these issues, but most likely, the test is not working as intended. |
| Comments |
| Comment by Gerrit Updater [ 13/Nov/19 ] |
|
James Nunez (jnunez@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36748 |
| Comment by Andreas Dilger [ 14/Nov/19 ] |
|
It looks like the "ofd.*.sync_on_lock_cancel" tunable was broken by patch https://review.whamcloud.com/33059 "LU-8066 ofd: migrate from proc to sysfs" due to implicit use of the function name as the parameter name. That patch was landed and is part of the 2.12.0 release, so we can't just revert the tunable name to "sync_on_lock_cancel". It also isn't just a matter of restoring the old tunable name, since the "mdt.*.sync_lock_cancel" name is also used since 2.8, and the code for the two tunables was recently consolidated in the server target code in patch https://review.whamcloud.com/34190 " Instead, I think the best path forward is to keep the common "sync_lock_cancel" tunable name for both MDT and OST, and add backward compatibility for "ofd.*.sync_on_lock_cancel" for a number of releases, and print a deprecation warning if the old name is used. |
| Comment by Andreas Dilger [ 14/Nov/19 ] |
|
It would make sense to write a conf-sanity test that extracts the "lctl list_param -R '*'" output on the client, MDS, and OSS, removes duplicate entries (e.g. removes instance (e.g. "-ffff012344567"), filesystem name (e.g. "lustre-"), NIDs (e.g. "192.168.10.1@tcp"), target index numbers (e.g. "OST0000" from parameters that make them unique to a specific mount/fsname/configuration), then sorts and removes duplicates and compares with a previously-saved parameter list. It should not be considered an error if new parameters are added, but it should be an error to remove existing parameters (or at least we will be notified of this and can make a proper decision about it). The lists should be saved with the version running on the current node (e.g. OSS, MDS, client) and not on the version of the test script, so that this does not cause errors during interop. The list can be updated right before a release so that we don't have to update the saved parameter list continually (though that is not bad either), but we also don't accidentally lose parameters between releases. |
| Comment by Gerrit Updater [ 14/Nov/19 ] |
|
Andreas Dilger (adilger@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/36754 |
| Comment by Gerrit Updater [ 16/Dec/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36748/ |
| Comment by Gerrit Updater [ 16/Dec/19 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36754/ |
| Comment by Peter Jones [ 16/Dec/19 ] |
|
Landed for 2.14 |
| Comment by Gerrit Updater [ 16/Dec/19 ] |
|
Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/37037 |
| Comment by Gerrit Updater [ 16/Dec/19 ] |
|
Minh Diep (mdiep@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/37038 |
| Comment by Gerrit Updater [ 03/Jan/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37037/ |
| Comment by Gerrit Updater [ 03/Jan/20 ] |
|
Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/37038/ |